Closed Bug 1526616 Opened 10 months ago Closed 9 months ago

[wpt-sync] Sync PR 15245 - [ElementTiming] Use TimingAllowOrigin check and remove bubbling

Categories

(Testing :: web-platform-tests, enhancement, P4)

enhancement

Tracking

(firefox67 fixed)

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 15245 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/15245
Details from upstream follow.

Nicolas Pena <npm@chromium.org> wrote:

[ElementTiming] Use TimingAllowOrigin check and remove bubbling

This CL changes the security check for ElementTiming from same-origin to
TAO, which requires plumbing the OriginalTimingAllowOrigin attribute for
the case of 304 responses. It also removes bubbling to be consistent with
ResourceTiming. Some tests are fixed to properly use cross-origins within
external/wpt, and a cross-origin resource with TAO wildcard test is
added. More TAO tests will be added in a followup.

Bug: 928425, 879270
Change-Id: I4df40818823e3db9851fbc9586a0bda9c1adcfec
Reviewed-on: https://chromium-review.googlesource.com/c/1453074
Commit-Queue: Nicolás Peña Moreno \<npm@chromium.org>
Reviewed-by: Yutaka Hirano \<yhirano@chromium.org>
Reviewed-by: Yoav Weiss \<yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630019}

Whiteboard: [wptsync downstream] → [wptsync downstream error]
PR 15245 applied with additional changes from upstream: 6e9d51e21f28557a5938d53eb66dbb86a334934d
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Ran 4 tests and 4 subtests
OK     : 4
PASS   : 3
FAIL   : 1

New tests that have failures or other problems:
/element-timing/image-TAO-wildcard.sub.html
    Cross-origin element with wildcard TAO is observed.: FAIL
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dcf8e575dc67
[wpt PR 15245] - [ElementTiming] Use TimingAllowOrigin check and remove bubbling, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/57f0ec9c5142
[wpt PR 15245] - Update wpt metadata, a=testonly
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c4e80aaaaef6
[wpt PR 15245] - [ElementTiming] Use TimingAllowOrigin check and remove bubbling, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/f0afe7269a90
[wpt PR 15245] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.