[wpt-sync] Sync PR 15283 - [Payment Request][WPT] Fix abort() tests.

RESOLVED FIXED in Firefox 67

Status

()

enhancement
P4
normal
RESOLVED FIXED
5 months ago
4 months ago

People

(Reporter: wptsync, Unassigned)

Tracking

unspecified
mozilla67
Points:
---

Firefox Tracking Flags

(firefox67 fixed)

Details

(Whiteboard: [wptsync downstream], )

Assignee

Description

5 months ago

Sync web-platform-tests PR 15283 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/15283
Details from upstream follow.

Rouslan Solomakhin <rouslan@chromium.org> wrote:

[Payment Request][WPT] Fix abort() tests.

Before this patch, the WPT tests for PaymentRequest.abort() were
expected to fail due to including the vendor testdriver JavaScript file
before the generic testdriver file. The vendor file was attempting to
use the objects defined in the generic file, but the incorrect include
order caused a JS error.

This patch reorders the vendor JS file to be after the generic JS file
and splits out the manual tests that require a user gesture for
PaymentRequest.show().

After this patch, the PaymentRequest.abort() tests are passing.

Bug: 929773
Change-Id: Ic0f8ff84b478116821e98775d1cec31cfad32d9f
Reviewed-on: https://chromium-review.googlesource.com/1459588
WPT-Export-Revision: 84300acf0a0e1f90e315fea91e25e8840bf66f6e

Assignee

Updated

5 months ago
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Assignee

Updated

4 months ago
Component: web-platform-tests → DOM: Web Payments
Product: Testing → Core
Assignee

Updated

4 months ago
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Assignee

Comment 3

4 months ago
Ran 1 tests and 2 subtests
OK     : 1
PASS   : 2

Comment 4

4 months ago
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/55f8f5e09d25
[wpt PR 15283] - [Payment Request][WPT] Fix abort() tests., a=testonly

Comment 5

4 months ago
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/98162bdbcabb
[wpt PR 15283] - [Payment Request][WPT] Fix abort() tests., a=testonly

Comment 6

4 months ago
bugherder
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.