Closed Bug 1526620 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 15285 - [Payment Request][WPT] Fix show() tests.

Categories

(Core :: DOM: Web Payments, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 15285 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/15285
Details from upstream follow.

Rouslan Solomakhin <rouslan@chromium.org> wrote:

[Payment Request][WPT] Fix show() tests.

Before this patch, the WPT tests for PaymentRequest.show() failed (and
were expected to do so) because the tests run in a content shell, which
does not have the Payment Request components sufficient for showing a
browser payment sheet.

This patch converts the show() test into a manual one, which should be
run in a full browser. One test case remains automated, because its
intent is to invoke show() without a user gesture. That test case is
expected to fail because Chromium does not require a user gesture for
show() at this time (https://crbug.com/817807).

After this patch, the manual WPT tests for PaymentRequest.show() pass in
the full Chromium browser.

Bug: 929773 817807
Change-Id: I9cacb5447fb3ae43a8b50c53a74b7c58db8f4466

Reviewed-on: https://chromium-review.googlesource.com/1460104
WPT-Export-Revision: d10b931dd8d61b19e13664386180e5dafeff95e4

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Component: web-platform-tests → DOM: Web Payments
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Ran 1 tests and 1 subtests
OK     : 1
PASS   : 1[linux32-opt,linux64-debug,linux64-opt]
FAIL   : 1[linux32-debug]
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fef6b005a837
[wpt PR 15285] - [Payment Request][WPT] Fix show() tests., a=testonly
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3c869fae6ed4
[wpt PR 15285] - [Payment Request][WPT] Fix show() tests., a=testonly
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.