[wpt-sync] Sync PR 15091 - Async Clipboard: Integrate readImage/writeImage into generic read/write

RESOLVED FIXED in Firefox 67

Status

()

enhancement
P4
normal
RESOLVED FIXED
4 months ago
3 months ago

People

(Reporter: wptsync, Unassigned)

Tracking

unspecified
mozilla67
Points:
---

Firefox Tracking Flags

(firefox67 fixed)

Details

(Whiteboard: [wptsync downstream], )

Assignee

Description

4 months ago

Sync web-platform-tests PR 15091 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/15091
Details from upstream follow.

Darwin Huang <huangdarwin@chromium.org> wrote:

Async Clipboard: Integrate readImage/writeImage into generic read/write

  • read/write now use Blobs instead of DataTransfer, and can only read/write one
    type at a time.
  • read/write can now read/write images in addition to existing text support.
  • readImageExperimental and writeImageExperimental removed.
  • Images will be encoded in the same manner as before this CL, whereas text
    will be emitted with utf-8 encoding.
  • read will prefer to return an image if one is available, and will return text
    otherwise.
  • Relevant tests updated.

Future Work:

  • Use vectors or lists or some collection of Blobs to read/write many types at
    a time, to work towards feature parity with DataTransfer.

Bug: 916823, 150835
Change-Id: I89d12ba137954731acb7180ac2fb6d15b0c264ae
Reviewed-on: https://chromium-review.googlesource.com/c/1435220
Commit-Queue: Darwin Huang \<huangdarwin@chromium.org>
Reviewed-by: Daniel Cheng \<dcheng@chromium.org>
Reviewed-by: Gary Kacmarcik \<garykac@chromium.org>
Reviewed-by: Victor Costan \<pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630205}

Assignee

Updated

4 months ago
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Assignee

Updated

4 months ago
Component: web-platform-tests → DOM
Product: Testing → Core
Assignee

Updated

4 months ago
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Assignee

Comment 3

4 months ago
Ran 1 tests and 11 subtests
OK     : 1
PASS   : 8
FAIL   : 3

Existing tests that now have a worse result (e.g. they used to PASS and now FAIL):
/clipboard-apis/async-navigator-clipboard-basics.https.html
    navigator.clipboard.read() succeeds: FAIL

New tests that have failures or other problems:
/clipboard-apis/async-navigator-clipboard-basics.https.html
    navigator.clipboard.write(Blob) succeeds: FAIL

Comment 4

4 months ago
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/edf27a067f59
[wpt PR 15091] - Async Clipboard: Integrate readImage/writeImage into generic read/write, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/b3909a782c84
[wpt PR 15091] - Update wpt metadata, a=testonly

Comment 5

4 months ago
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7bc2cad59f4c
[wpt PR 15091] - Async Clipboard: Integrate readImage/writeImage into generic read/write, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/c04a06748b81
[wpt PR 15091] - Update wpt metadata, a=testonly

Comment 6

4 months ago
bugherder
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.