Closed Bug 1526638 Opened 7 months ago Closed 7 months ago

[fr] Fluent: Move localizations from Variants to Macros

Categories

(Mozilla Localizations :: fr / French, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: flod, Assigned: flod)

References

()

Details

Attachments

(1 file, 1 obsolete file)

Not exactly sure how, but we missed that French is using Variants. Noticed this morning because a string was changed. Filing a bug for visibility.

With Fluent Syntax 0.8 Variants are deprecated and we need to migrate these translations to macros.

This task is going to be managed by l10n-drivers directly, please don't make changes.

Attached patch bug1526638.patch (obsolete) — Splinter Review

I've set "lowercase" as the default, since it's used 4 out of 5 times.

Also, since -fxaccount-brand-name is a term, there's no risk of it being used as a stand-alone title, it can be used only in another message.

Attachment #9042721 - Flags: review?(theo)
Comment on attachment 9042721 [details] [diff] [review]
bug1526638.patch

`options-use-sync` needs lowercase as well, I added a suggestion in Pontoon yesterday to do just that, and left it as a suggestion for the other localizers to notice when approving, but let’s probably just change it here to avoid confusion.

Looks good otherwise!

Note that we’re using variants quite heavily on Firefox Monitor as well.
Attachment #9042721 - Flags: review?(theo)
Attached patch bug1526638.patchSplinter Review
Attachment #9042721 - Attachment is obsolete: true
Attachment #9042732 - Flags: review?(theo)

(In reply to Théo Chevalier [:tchevalier] (please use NI) from comment #2)

Note that we’re using variants quite heavily on Firefox Monitor as well.

Firefox Monitor needs to be fixed as well, you can do it directly in Pontoon.

It looks like you started using it only recently? Because we converted locales there too
https://github.com/mozilla/blurts-server/pull/668/files

(In reply to Francesco Lodolo [:flod] from comment #4)

It looks like you started using it only recently?

That was a dumb question, since we added those strings this week. I'll need to keep an eye on ru and uk to make sure they use the new syntax.

For clarity, both work at the moment, but the variantList is already deprecated and will stop working at some point.

Attachment #9042732 - Flags: review?(theo) → review+
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.