1526672 - In browser_all_files_referenced.js, touchbar.ftl flagged as unreferenced on Windows/Linux

Status: RESOLVED WONTFIX

(Firefox :: General, defect)

Description

[Avery Berninger]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.98 Safari/537.36

Steps to reproduce:

Running browser_all_files_referenced on Windows/Linux (or try server) shows that touchbar.ftl is unreferenced.

Try server results: https://treeherder.mozilla.org/#/jobs?repo=try&revision=056b780ff49acfdadca19fff6234499a9ef09d48

Actual results:

touchbar.ftl is only used on MacOs, it will be flagged as unreferenced on Windows/Linux.

Expected results:

touchbar.ftl should not be listed as unreferenced on any platform.

Comment 1

[:Gijs (he/him)]

So options are:

• accept that we ship the unnecessary l10n file on windows/linux
• find a reasonable way of shipping per-platform l10n files, like we do for .properties / .dtds , without messing too much with the *.ftl syntax thing.

:Pike/:flod, I assume you have thoughts on this.

Comment 2

[Axel Hecht [:Pike]]

(In reply to :Gijs (he/him) from comment #1)

So options are:

• accept that we ship the unnecessary l10n file on windows/linux

We shall do this ...

• find a reasonable way of shipping per-platform l10n files, like we do for .properties / .dtds , without messing too much with the *.ftl syntax thing.

.. because we don't allow this. Doing so makes language packs platform-dependent, which we don't support.

We used to do that in the past, and that was a bug.

Comment 3

[:Gijs (he/him)]

(In reply to Axel Hecht [:Pike] from comment #2)

(In reply to :Gijs (he/him) from comment #1)

So options are:

• accept that we ship the unnecessary l10n file on windows/linux

We shall do this ...

• find a reasonable way of shipping per-platform l10n files, like we do for .properties / .dtds , without messing too much with the *.ftl syntax thing.

.. because we don't allow this. Doing so makes language packs platform-dependent, which we don't support.

We used to do that in the past, and that was a bug.

Why would it make language packs platform-dependent? Isn't this just about mozilla-central?

Comment 4

[Axel Hecht [:Pike]]

No idea what you have in mind. If you're thinking of platform #if in jar.mn, they're not allowed in locales/jar.mn anymore. Sadly, we don't have tests for that.

Comment 5

[:Gijs (he/him)]

(In reply to Axel Hecht [:Pike] from comment #4)

No idea what you have in mind. If you're thinking of platform #if in jar.mn, they're not allowed in locales/jar.mn anymore. Sadly, we don't have tests for that.

Well, there are entire directories whose moz.build files aren't included on some OSes, which would be one way of doing this, if it'd be problematic to have the #ifdef directly in jar.mn .

Comment 6

[Axel Hecht [:Pike]]

Yes, if that happens, that's a bug. Please file and CC me and Callek.

Comment 7

[:Gijs (he/him)]

Alright, sounds like we don't want to change anything here?

It still seems unfortunate to have to ship unused strings, but it sounds like we have no plans to make it possible/easy to support that.