[wpt-sync] Sync PR 15284 - [css-grid] Overflow should be computed with the actual logical bottom

RESOLVED FIXED in Firefox 67

Status

enhancement
P4
normal
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: wptsync, Unassigned)

Tracking

unspecified
mozilla67
Points:
---

Firefox Tracking Flags

(firefox67 fixed)

Details

(Whiteboard: [wptsync downstream], )

Assignee

Description

4 months ago

Sync web-platform-tests PR 15284 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/15284
Details from upstream follow.

Javier Fernandez <jfernandez@igalia.com> wrote:

[css-grid] Overflow should be computed with the actual logical bottom

In order to compute the 'auto' height of the grid container, we set
temporarily a value based on the tracks' size. We can see this value as
a kind of 'intrinsic height'. Then, we call to the UpdateLogicalHeight
function to finally compute the grid container's actual logical height.

In order to compute the overflow area in the grid container we should
use the result of the ClientLogicalBottom function. However, we were
retrieving this value just after setting the tracks-based temporary
height, and before computing the actual logical height.

The consequence of this wrong logic is that empty grid areas may
affect the result of the ClientLogicalBottom and, as it's described
in the bug, conclude that there is a content overflow in the grid
container, even if such container has no grid items at all.

Since the grid itself is not a box, it can't contribute to the grid
container's content size; instead, its grid items should.

This change ensures that we always use the actual grid container's
logical bottom to properly compute the overflow area.

Bug: 928885
Change-Id: I05f86fbce06a83c0dbc0d5389bf0416763f8588a
Reviewed-on: https://chromium-review.googlesource.com/1459620
WPT-Export-Revision: 53fad3ac87218d71e5310782c9482f37f1edc593

Assignee

Updated

4 months ago
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Assignee

Updated

4 months ago
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Assignee

Updated

4 months ago
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Assignee

Comment 3

4 months ago
Ran 8 tests
PASS   : 8
Assignee

Updated

4 months ago
Component: CSS Parsing and Computation → web-platform-tests
Product: Core → Testing

Comment 4

4 months ago
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4b473920911b
[wpt PR 15284] - [css-grid] Overflow should be computed with the actual logical bottom, a=testonly

Comment 5

4 months ago
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d979f778d2f8
[wpt PR 15284] - [css-grid] Overflow should be computed with the actual logical bottom, a=testonly

Comment 6

4 months ago
bugherder
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.