1526765 - TB65: thread is collapsed automatically when double clicking first message/article of thread to open it

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Christian Riechers]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:66.0) Gecko/20100101 Firefox/66.0

Steps to reproduce:

Thunderbird 65.0b4 64-bit, Linux OpenSUSE Leap 15.0, Gnome 3.26.2

Reading newsgroup messages in e.g. mozilla.support.thunderbird on news.mozilla.org.

1. expanding a given thread
2. double-clicking the first message in the expanded thread

Actual results:

1. message opens in a new window
2. the thread gets automatically collapsed in the main window

Expected results:

The thread should not auto-collapse upon opening the message.

Comment 1

[Wayne Mery (:wsmwk)]

Does this happen also with version 60? Or earlier?

Comment 2

[Christian Riechers]

No, I think this started with v65.

Comment 3

[Wayne Mery (:wsmwk)]

I can confirm this on Windows. DOesn't happen with TB60.
Now we just need a regression range with daily

Comment 4

[Wayne Mery (:wsmwk)]

Also happens with mail. Can you find egression range with daily?

Comment 5

[Christian Riechers]

Using Linux:
Last 'good' version is 65.0a1 (2018-11-17) (64-bit)
First 'broken' version is 65.0a1 (2018-11-18) (64-bit)

Comment 6

[Wayne Mery (:wsmwk)]

Benjamin, this has a regression range, so perhaps easy to fix
Christian, thanks for the range!

Comment 7

[Christian Riechers]

Unfortunately the problem hasn't magically disappeared since the last comment was made 2 month ago, and it is still present in TB71 daily.

Comment 8

[Wayne Mery (:wsmwk)]

(In reply to Christian Riechers from comment #5)

Using Linux:
Last 'good' version is 65.0a1 (2018-11-17) (64-bit)
First 'broken' version is 65.0a1 (2018-11-18) (64-bit)

https://hg.mozilla.org/comm-central/pushloghtml?startdate=2018-11-17+04%3A00%3A00&enddate=2018-11-18+4%3A00%3A00

I cannot reproduce this with 72.0b3 on Windows. Is it linux only?

Comment 9

[Magnus Melin [:mkmelin]]

It's reproducible, oddly not if the msg is set to open in a new tab.

Comment 10

[Magnus Melin [:mkmelin]]

Attachment: bug1526765_thread_pane_dblclick.patch

Probably a regression from tree.xml de-xbl

The comments around here were not really correct, at least anymore.
The event.stopPropagation() was not working, since it's the dblclick handler that causes it, not the click handler. Also too late I think.

Comment 11

[Paul Morris [:pmorris]]

Comment on attachment 9119681 [details] [diff] [review]
bug1526765_thread_pane_dblclick.patch

Review of attachment 9119681 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM with one typo nit to fix.  I checked that the problem does not occur for me with threaded email (on linux) with this patch applied.

::: mail/base/content/threadPane.js
@@ +454,5 @@
> +    event => {
> +      // The tree.js dblclick event handler is handling editing and toggling
> +      // open state of the cell. We don't use editing, and we want to handle
> +      // the toggling through the click handler (also for double click), so
> +      // capture the dblclick event before it bubbles up and cause the

cause -> causes

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/be621c5c7cd3
make dblclick on first message in closed thread keep the cell open state. r=pmorris DONTBUILD

Comment 13

[Jorg K (CEST = GMT+2)]

DONTBUILD needs to be on the topmost changeset or it has no effect:
https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=74fb2e349d4e09a6b5c956e4a5c83476ea23cc2c

Comment 14

[Magnus Melin [:mkmelin]]

Ah yes, accidentally reordered them.

Comment 15

[Wayne Mery (:wsmwk)]

This is a regression in 68 and it seems simple. Safe and ready to take for ESR? If so, please request uplift.

Comment 16

[Magnus Melin [:mkmelin]]

Comment on attachment 9119681 [details] [diff] [review]
bug1526765_thread_pane_dblclick.patch

Should be safe.

Comment 17

[Wayne Mery (:wsmwk)]

Comment on attachment 9119681 [details] [diff] [review]
bug1526765_thread_pane_dblclick.patch

Approved for ESR

Comment 18

[Magnus Melin [:mkmelin]]

Thunderbird 68.7: https://hg.mozilla.org/releases/comm-esr68/rev/fe08fd3b20fa58248db25470e14c0a6427f6503a