nsMsgCompose::CheckAndPopulateRecipients takes PRUint32 retval but puts -1 in it

RESOLVED WORKSFORME

Status

MailNews Core
Composition
RESOLVED WORKSFORME
16 years ago
10 years ago

People

(Reporter: Akkana Peck, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

16 years ago
nsMsgCompose.cpp spews quite a number of warnings when you compile it.  Some of
these are comparison between signed and unsigned (probably harmless) but some of
them concern assignments of -1 to *_retval in
nsMsgCompose::CheckAndPopulateRecipients(), which is declared as PRUint32.  This
may be causing hidden bugs ...
QA Contact: esther → stephend

Comment 1

14 years ago
Works for me (and for Neil Rashbrook). -1's are nowhere to be seen, and
compiling nsMsgCompose.cpp emits 4 warnings, all regarding AttachPrettyName(),
not CheckAndPopulateRecipients(). This does not change the (in my view) fact of
CheckAndPopulateRecipients()'s being a very problematic creature; see bug 246089.
Product: MailNews → Core

Updated

10 years ago
Assignee: ducarroz → nobody
QA Contact: stephend → composition
(Assignee)

Updated

10 years ago
Product: Core → MailNews Core
(In reply to comment #1)
> Works for me (and for Neil Rashbrook). -1's are nowhere to be seen, and
> compiling nsMsgCompose.cpp emits 4 warnings, all regarding AttachPrettyName(),
> not CheckAndPopulateRecipients(). This does not change the (in my view) fact of
> CheckAndPopulateRecipients()'s being a very problematic creature; see bug 246089.

I see no problems either. I agree that we should probably be checking the return value, but that's for other bugs.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.