152679 - nsMsgCompose::CheckAndPopulateRecipients takes PRUint32 retval but puts -1 in it

Status: RESOLVED WORKSFORME

(MailNews Core :: Composition, defect)

Description

[Akkana Peck]

nsMsgCompose.cpp spews quite a number of warnings when you compile it.  Some of
these are comparison between signed and unsigned (probably harmless) but some of
them concern assignments of -1 to *_retval in
nsMsgCompose::CheckAndPopulateRecipients(), which is declared as PRUint32.  This
may be causing hidden bugs ...

Comment 1

[Eyal Rozenberg]

Works for me (and for Neil Rashbrook). -1's are nowhere to be seen, and
compiling nsMsgCompose.cpp emits 4 warnings, all regarding AttachPrettyName(),
not CheckAndPopulateRecipients(). This does not change the (in my view) fact of
CheckAndPopulateRecipients()'s being a very problematic creature; see bug 246089.

Comment 2

[Mark Banner (:standard8)]

(In reply to comment #1)
> Works for me (and for Neil Rashbrook). -1's are nowhere to be seen, and
> compiling nsMsgCompose.cpp emits 4 warnings, all regarding AttachPrettyName(),
> not CheckAndPopulateRecipients(). This does not change the (in my view) fact of
> CheckAndPopulateRecipients()'s being a very problematic creature; see bug 246089.

I see no problems either. I agree that we should probably be checking the return value, but that's for other bugs.