1526826 - MozElements.BaseText doesn't inherit from MozElements.BaseControl

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task, P3)

Description

[Brian Grinstead [:bgrins]]

The "basetext" binding inherits "basecontrol" in XBL: https://bgrins.github.io/xbl-analysis/tree/.

But the BaseTextMixin doesn't inherit the BaseControlMixin: https://searchfox.org/mozilla-central/rev/5e3bffe964110b8d1885b4236b8abd5c94d8f609/toolkit/content/customElements.js#316. This means properties like "disabled" don't get added to MozElements.BaseText instances.

Comment 1

[Brian Grinstead [:bgrins]]

I think this should fix it:

-const BaseTextMixin = Base => class extends Base {
+const BaseTextMixin = Base => class extends BaseControlMixin(Base) {

Comment 2

[Brian Grinstead [:bgrins]]

Attachment: Bug 1526826 - Make BaseTextMixin extend BaseControlMixin

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c589a17c80d5
Make BaseTextMixin extend BaseControlMixin r=surkov

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/c589a17c80d5