Closed Bug 1526826 Opened 9 months ago Closed 9 months ago

MozElements.BaseText doesn't inherit from MozElements.BaseControl

Categories

(Toolkit :: XUL Widgets, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: bgrins, Assigned: bgrins)

References

Details

Attachments

(1 file)

The "basetext" binding inherits "basecontrol" in XBL: https://bgrins.github.io/xbl-analysis/tree/.

But the BaseTextMixin doesn't inherit the BaseControlMixin: https://searchfox.org/mozilla-central/rev/5e3bffe964110b8d1885b4236b8abd5c94d8f609/toolkit/content/customElements.js#316. This means properties like "disabled" don't get added to MozElements.BaseText instances.

I think this should fix it:

-const BaseTextMixin = Base => class extends Base {
+const BaseTextMixin = Base => class extends BaseControlMixin(Base) {
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Priority: -- → P3
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c589a17c80d5
Make BaseTextMixin extend BaseControlMixin r=surkov
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Type: defect → task
You need to log in before you can comment on or make changes to this bug.