Closed Bug 1526860 Opened 10 months ago Closed 10 months ago

[wpt-sync] Sync PR 15214 - Round up to the next render quantum for suspend

Categories

(Core :: Web Audio, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 15214 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/15214
Details from upstream follow.

Raymond Toy <rtoy@chromium.org> wrote:

Round up to the next render quantum for suspend

OfflineAudioContext.suspend rounds the time up to the next render
quantum instead of down. It is sometimes confusing when suspend
occurs before the given time, which is different from how everything
else works in WebAudio.

A few tests need to be fixed because they computed the boundary by
rounding down instead of up. One test needed to be adjusted because
the times were rounded to different boundaries instead of the same
boundary.

See also https://github.com/WebAudio/web-audio-api/issues/1822

Bug: 927895
Change-Id: Ie6685c620dd38eb2a059901d13b907764ba1a2db
Reviewed-on: https://chromium-review.googlesource.com/c/1450536
Reviewed-by: Kent Tamura \<tkent@chromium.org>
Reviewed-by: Hongchan Choi \<hongchan@chromium.org>
Commit-Queue: Raymond Toy \<rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630346}

Component: web-platform-tests → Web Audio
Product: Testing → Core
Ran 2 tests and 4 subtests
PASS   : 4
ERROR  : 2
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5255301763d0
[wpt PR 15214] - Round up to the next render quantum for suspend, a=testonly
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dcf9f8a30353
[wpt PR 15214] - Round up to the next render quantum for suspend, a=testonly
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.