Closed Bug 1526861 Opened 1 year ago Closed 1 year ago

New Tab : Incorrect numbers listed for numbered list sections

Categories

(Firefox :: New Tab Page, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 67
Iteration:
67.1 - Jan 28 - Feb 10
Tracking Status
firefox-esr60 --- unaffected
firefox65 --- unaffected
firefox66 + verified
firefox67 --- verified

People

(Reporter: bnagabandi, Assigned: thecount)

References

Details

(Keywords: github-merged, regression)

Attachments

(2 files)

As of today's build
FF Nightly version : 67.0a1 (2019-02-10)
OS : Mac and Windows 10 Pro

Latest end-point dev-test-all has incorrect numbers for all numbered list sections.

Depends on: 1522299

I would guess bug 1519879 regressed this with the changes to the html structure of lists?

Blocks: 1519879
Flags: needinfo?(pdahiya)
Keywords: regression
Iteration: --- → 67.1 - Jan 28 - Feb 10
Priority: -- → P1
Duplicate of this bug: 1526997

To test:

  1. Set the pref browser.newtabpage.activity-stream.discoverystream.config to {"enabled":true,"show_spocs":true,"layout_endpoint":"https://getpocket.com/v3/newtab/layout?version=1&consumer_key=40249-e88c401e1b1f2242d9e441c4&layout_variant=dev-test-all"}
  2. Go to about:home
  3. Scroll down a bit until you see a numbered list item. (Should be just below the fold, three numbers items with circle blue list numbers)

Expected: Should see a list going 1, 2, 3.
Actual: See a list with items going 1, 1, 1.

This is caused by the spoc changes to List, we added the intersection observer component around the list item element, which now breaks it out of the css needed for content: counter(list); which seems to make it think it's a bunch of 1 item lists.

One initial option is to swap the li element and the intersection observer component's order, seems to fix it and list spocs still works?

Assignee: nobody → pdahiya
Assignee: pdahiya → sdowne

Clearing NI, thanks Scott for picking this one!

Flags: needinfo?(pdahiya)

[Tracking Requested - why for this release]:

Fixes numbering list regressed in bug 1519879 fix.

Blocks: 1527504
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
Status: RESOLVED → VERIFIED

Brahmini, can you verify that the list numbers are fixed on nightly? See steps here: https://bugzilla.mozilla.org/show_bug.cgi?id=1526861#c3

Flags: needinfo?(bnagabandi)
Status: VERIFIED → REOPENED
Flags: needinfo?(bnagabandi)
Resolution: FIXED → ---
Status: REOPENED → RESOLVED
Closed: 1 year ago1 year ago
Resolution: --- → FIXED

Can you add an uplift request for this as well?

Flags: needinfo?(pdahiya)

Comment on attachment 9043739 [details]
Bug 1526861 - Incorrect numbers listed for numbered list sections

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

Bug 1519879

User impact if declined

User will see list items incorrectly numbered

Is this code covered by automated tests?

No

Has the fix been verified in Nightly?

Yes

Needs manual test from QE?

Yes

If yes, steps to reproduce

  1. Set the pref browser.newtabpage.activity-stream.discoverystream.config to {"enabled":true,"show_spocs":true,"layout_endpoint":"https://getpocket.com/v3/newtab/layout?version=1&consumer_key=40249-e88c401e1b1f2242d9e441c4&layout_variant=dev-test-all"}
  2. Go to about:home
  3. Scroll down a bit until you see a numbered list item. (Should be just below the fold, three numbers items with circle blue list numbers)

Expected: Should see a list going 1, 2, 3.
Actual: See a list with items going 1, 1, 1.

List of other uplifts needed

Bug 1519879

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

Very low risk small patch. Fixes regression from 1519879 patch that displays sponsored content in list for discovery new tab experiments.

String changes made/needed

None

Flags: needinfo?(pdahiya)
Attachment #9043739 - Flags: approval-mozilla-beta?

I have verified in Nightly 67.0a1 on Mac OS 10.14.3 that the numbers for the numbered list module are being displayed correctly!

Comment on attachment 9043739 [details]
Bug 1526861 - Incorrect numbers listed for numbered list sections

Planned work for pocket/new tab. Verified in Nightly.
OK for beta uplift, should land for beta 9.
Landing order: bug 1519879, bug 1525494, bug 1526861, bug 1524669, bug 1527195, bug 1525391, bug 1527347, bug 1525366, bug 1527626, bug 1527397, bug 1518258, bug 1527701, bug 1527370.

Attachment #9043739 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

(In reply to Wolasi from comment #14)

I have verified in Nightly 67.0a1 on Mac OS 10.14.3 that the numbers for the
numbered list module are being displayed correctly!

Can you please verify this issue on Firefox 66 Beta 9 (https://archive.mozilla.org/pub/firefox/candidates/66.0b9-candidates/build1/)?

Flags: qe-verify+
Flags: needinfo?(wkonu)

I have verified in Beta 66.0b9 on Mac OS 10.14.3 that the numbers for the numbered list module are being displayed correctly

Flags: needinfo?(wkonu)

(In reply to Wolasi from comment #18)

I have verified in Beta 66.0b9 on Mac OS 10.14.3 that the numbers for the
numbered list module are being displayed correctly

Thanks for verifying this!

Flags: qe-verify+
See Also: → 1531099
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.