1526897 - typo in SIGBUS / BUS_ADRALN annotation

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect, P4)

Description

[Julien Cristau [:jcristau]]

SIGBUS with si_code set to BUS_ADRALN is turned into "SIGBUS / BUS_ADALN".
Seeing this in crash-stats has been bugging me for a bit :)

Comment 1

[Gabriele Svelto [:gsvelto] (PTO)]

This is still in the breakpad code we haven't forked and it needs to be fixed in Socorro right? In that case we'll have to send it to upstream breakpad first. I can review your patch there too, you'll need to open an issue here:

https://bugs.chromium.org/p/google-breakpad/issues/list

Then follow the instructions here (scroll down to "Getting started") to upload the patch:

https://chromium.googlesource.com/breakpad/breakpad/

Then ask for review to me or Ted.

If that feels like too much of an hassle - which it is, no judgements ;) - I can do it for you.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Once this is fixed in breakpad, I can handle writing up a Socorro bug to update Socorro and fixing it there.

Comment 3

[Julien Cristau [:jcristau]]

I wasn't sure which part of breakpad was forked and which wasn't... Issue is https://bugs.chromium.org/p/google-breakpad/issues/detail?id=787, patch at https://chromium-review.googlesource.com/c/breakpad/breakpad/+/1466365

Sorry about the hassle for such a trivial thing, now I'll have to contribute something meaningful to make it worth it :)