Closed Bug 1526941 Opened 1 year ago Closed 1 year ago

Make nsDisplayTransform smaller

Categories

(Core :: Web Painting, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: miko, Assigned: miko)

References

(Blocks 2 open bugs)

Details

Attachments

(5 files)

Currently transform display item uses 1KB of memory. We can shrink this to almost half by changing nsDisplayTransform to derive from nsDisplayWrapList, instead of having child display items in a member variable |nsDisplayTransform::mStoredList|.

Assignee: nobody → mikokm
Status: NEW → ASSIGNED
Priority: P1 → P2
Attachment #9046637 - Attachment description: Bug 1526941 - Part 3: Use mozilla::Maybe for mTransformPreserves3D and remove the cached inverse transform r=mattwoodrow → Bug 1526941 - Part 3: Use mozilla::UniquePtr for mTransformPreserves3D r=mattwoodrow
Pushed by mikokm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/894310bf6264
Part 1: Simplify nsDisplayTransform constructors r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/e2228efd2dc0
Part 2: Refactor nsDisplayWrapList::GetComponentAlphaBounds() and nsDisplayWrapList::GetOpaqueRegion() and move some of the logic to nsDisplayList r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/57c633e6cb44
Part 3: Use mozilla::UniquePtr for mTransformPreserves3D r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/c5a66f2c239f
Part 4: Remove mStoredList from nsDisplayTransform r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/02fe822afa8c
Part 5: Rewrite nsDisplayTransform bounds calculations r=mattwoodrow
Regressions: 1553828
You need to log in before you can comment on or make changes to this bug.