Closed Bug 1526981 Opened 3 years ago Closed 3 years ago

Broken logging in chrome JS modules

Categories

(GeckoView :: General, defect, P1)

Product:
GeckoView
Component:
General
Platform:
Unspecified
All
Type:
defect

Tracking

(firefox-esr60 unaffected, firefox65 unaffected, firefox66 unaffected, firefox67 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla67
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox65 --- unaffected
firefox66 --- unaffected
firefox67 --- fixed

People

(Reporter: esawin, Assigned: esawin)

References

Details

Attachments

(2 files)

Bug 1526981 - [1.1] Remove obsolete module import.
47 bytes, text/x-phabricator-request
Details | Review
Bug 1526981 - [2.4] Simplify JSM module logger initialization and ensure compatibility with ES6.
47 bytes, text/x-phabricator-request
Details | Review

Bug 1514594 has changed mechanics around ChromeUtils.import which apparently brakes our use case in ModuleInfo._loadPhase() used for calling into GeckoViewUtils.initLogging().

This results in broken logs for parent process GeckoSession JS modules.

Kris, is this expected and how do we fix this?

Flags: needinfo?(kmaglione+bmo)

This is expected, yes. You can still get the module global for the moment by passing null as the second argument to ChromeUtils.import, but module globals are going away entirely, so that's a short-term workaround at best.

Flags: needinfo?(kmaglione+bmo)
Assignee: nobody → esawin
Attachment #9043429 - Attachment description: Bug 1526981 - [2.0] Simplify module logging initialization. → Bug 1526981 - [2.1] Simplify module logging initialization.
Attachment #9043429 - Attachment description: Bug 1526981 - [2.1] Simplify module logging initialization. → Bug 1526981 - [2.2] Simplify module logging initialization.

P1 because logging is important.

status-firefox65: --- → wontfix
status-firefox66: --- → wontfix
status-firefox67: --- → affected
status-firefox-esr60: --- → wontfix
Priority: -- → P1
Attachment #9043429 - Attachment description: Bug 1526981 - [2.2] Simplify module logging initialization. → Bug 1526981 - [2.3] Simplify JSM module logger initialization and ensure compatibility with ES6.
Attachment #9043429 - Attachment description: Bug 1526981 - [2.3] Simplify JSM module logger initialization and ensure compatibility with ES6. → Bug 1526981 - [2.4] Simplify JSM module logger initialization and ensure compatibility with ES6.
Attachment #9043428 - Attachment description: Bug 1526981 - [1.0] Remove obsolete module import. → Bug 1526981 - [1.1] Remove obsolete module import.
Pushed by esawin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/67f5e231032c
[1.1] Remove obsolete module import. r=kmag
https://hg.mozilla.org/integration/autoland/rev/181e9d842ebd
[2.4] Simplify JSM module logger initialization and ensure compatibility with ES6. r=geckoview-reviewers,agi

https://hg.mozilla.org/mozilla-central/rev/67f5e231032c
https://hg.mozilla.org/mozilla-central/rev/181e9d842ebd

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox67: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.