Closed Bug 1526998 Opened 2 years ago Closed 2 years ago

Markers for nsIObserverService::NotifyObserver calls would be useful

Categories

(Core :: Gecko Profiler, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: florian, Assigned: florian)

References

(Depends on 1 open bug)

Details

Attachments

(1 file)

Seeing in the marker chart of profiles which observer service notifications are fired when and how long we are blocked on them would help make sense of some profiles.

Here is an example on a shutdown profile: https://perfht.ml/2Dsnsjf

The patch I have for this collects the stack, but I could be convinced to omit it if we are afraid collecting stacks would have too much overhead. In the profiles I've seen when trying locally, we don't seem to call this often enough for the stack overhead to be an actual problem, and I guess the stack could be helpful.

Pushed by fqueze@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4394e1f91db8
Show markers for nsObserverService notifications, r=mstange.
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Depends on: 1528612
You need to log in before you can comment on or make changes to this bug.