Closed
Bug 1526998
Opened 5 years ago
Closed 5 years ago
Markers for nsIObserverService::NotifyObserver calls would be useful
Categories
(Core :: Gecko Profiler, enhancement)
Core
Gecko Profiler
Tracking
()
RESOLVED
FIXED
mozilla67
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: florian, Assigned: florian)
References
Details
Attachments
(1 file)
Seeing in the marker chart of profiles which observer service notifications are fired when and how long we are blocked on them would help make sense of some profiles.
Here is an example on a shutdown profile: https://perfht.ml/2Dsnsjf
The patch I have for this collects the stack, but I could be convinced to omit it if we are afraid collecting stacks would have too much overhead. In the profiles I've seen when trying locally, we don't seem to call this often enough for the stack overhead to be an actual problem, and I guess the stack could be helpful.
|
Assignee | |
Comment 1•5 years ago
|
||
Pushed by fqueze@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4394e1f91db8 Show markers for nsObserverService notifications, r=mstange.
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in
before you can comment on or make changes to this bug.
Description
•