WebSocketChannel hangs waiting for OnTransportAvailable when server responds to upgrade request with HTTP/1.0

RESOLVED FIXED in Firefox 67

Status

()

P2
normal
RESOLVED FIXED
a month ago
a month ago

People

(Reporter: michal, Assigned: michal)

Tracking

(Blocks: 1 bug)

Trunk
mozilla67
Points:
---

Firefox Tracking Flags

(firefox67 fixed)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 attachment)

(Assignee)

Description

a month ago

When server responds with "HTTP/1.0 101 Switching Protocols" to an upgrade request we process the response and wait for WebSocketChannel::OnTransportAvailable which is never called because the upgrade isn't performed for HTTP/1.0 at https://searchfox.org/mozilla-central/rev/00c0d068ece99717bea7475f7dc07e61f7f35984/netwerk/protocol/http/nsHttpChannel.cpp#7595.

(Assignee)

Comment 1

a month ago
Posted patch fixSplinter Review
Attachment #9043037 - Flags: review?(dd.mozilla)
Attachment #9043037 - Flags: review?(dd.mozilla) → review+
Priority: P1 → P2
Whiteboard: [necko-triaged]
(Assignee)

Updated

a month ago
Keywords: checkin-needed

Comment 2

a month ago

Pushed by opoprus@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/609114233603
WebSocketChannel hangs waiting for OnTransportAvailable when server responds to upgrade request with HTTP/1.0, r=dragana

Keywords: checkin-needed

Comment 3

a month ago
bugherder
Status: NEW → RESOLVED
Last Resolved: a month ago
status-firefox67: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.