Don't install nasm on Linux if if is already installed locally
Categories
(Firefox Build System :: Bootstrap Configuration, defect)
Tracking
(firefox67 fixed)
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: KaiE, Assigned: KaiE)
Details
Attachments
(1 file, 1 obsolete file)
I'm using a debian 9 for development.
The nasm available as a distribution package is too old and doesn't work with the mozilla build.
To fix that, I've locally installed nasm, and it's in the search path.
Nevertheless, whenever I run "mach bootstrap" for other reasons, it wants to install the system package again. If both system nasm and local nasm are available, then the mozilla build prefers to use the system one, and fails.
Would it be possible to change mach bootstrap to:
- check if nasm is available in the search path (which nasm) and if the version is sufficiently new, and if yes, don't install the system package?
|
||
Comment 1•5 years ago
|
||
Yes, we already have this exact logic for several packages including Python, Mercurial and Rust:
https://searchfox.org/mozilla-central/rev/00c0d068ece99717bea7475f7dc07e61f7f35984/python/mozboot/mozboot/base.py#648-678
Fixing this would require moving nasm out of the fixed list of packages here:
https://searchfox.org/mozilla-central/rev/00c0d068ece99717bea7475f7dc07e61f7f35984/python/mozboot/mozboot/debian.py#69
and then adding some special handling in ensure_browser_packages:
https://searchfox.org/mozilla-central/rev/00c0d068ece99717bea7475f7dc07e61f7f35984/python/mozboot/mozboot/debian.py#132-134
|
Assignee | |
Comment 2•5 years ago
|
||
This helps me.
|
|
Assignee | |
Comment 3•5 years ago
|
||
|
|
Assignee | |
Updated•5 years ago
|
Pushed by kaie@kuix.de: https://hg.mozilla.org/integration/mozilla-inbound/rev/fb152321cbbf Don't install nasm on Linux if it is already installed locally, r=ted
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
Description
•