1527027 - "warn before closing tabs" not honored for "close tabs to right" action

Status: RESOLVED INVALID

(Firefox :: Tabbed Browser, defect)

Description

[hwine]

STR:

1. Set browser.tabs.warnOnCloseOtherTabs to true (I no longer see an option preference for this, but I know there used to be one)

2. Open a new window with multiple tabs

3. Click the close window icon, and verify a warning is presented (click "cancel")

4. Right click on a tab, and choose "Close Tabs to the Right"

What happens:

• all tabs to the right are closed without warning.

What I expected:

• to get a warning prompt about closing multiple tabs

Build ID: 20190210213844

Comment 1

[Mats Palmgren (inactive)]

I think this is an intentional change made in bug 1135303.

Comment 2

[hwine]

Ah that does appear to be the culprit. Personally, I would have opted for a different interpretation, as bug 1135303 comment 0 described about a different situation than I experienced. (I have the "warn on closing multiple tabs" enabled.)

Leaving this open, as I think all the discussion suggests the need to have a good, understandable, story on SUMO by the time this releases. I suspect it may confuse folks like me, who thought the old behavior was correct. :/

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

The desired outcome of the bug changed from bug 1135303 comment 0 to bug 1135303 comment 6. As we have more users coming to Firefox from Chrome, we want to match the Chrome behavior closer. Chrome does not prompt when closing multiple tabs but does allow for Undo Close Tab (which we do as well). I did find that Chrome only restores up to 25 tabs, which we now do as well (bug 1135303 increased our limit). However if more than 25 tabs are requested to close then we do show the prompt since there could be dataloss.

It is fine to keep this bug open to discuss if we should keep the change from bug 1135303 but this is currently acting as intended and I don't see a clear reason to revert the behavior.

Comment 4

[sdaniele3]

I recently updated my Firefox and encountered this issue. I'm quite disappointed with the change. But at least we still get a warning if we can't undo the operation.