1527118 - Not all tests use tooltool caches

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, enhancement)

Description

[Chris AtLee [:catlee]]

When poking around some logs, I noticed that not all of our tests make use of tooltool caches on the worker, resulting in having to download the same artifacts over and over again.

For example:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=227744668&repo=autoland&lineNumber=15 says that "changing ownership of volume /builds/worker/tooltool-cache", but that directory hasn't been declared as a cache in the task definition here: https://tools.taskcluster.net/groups/EqFAm8SBSBSbpYhTmPKZjw/tasks/cwAMcFZ5Si2aVFcY3L7-QA/details

Also, in many cases the tooltool.py invocation does not properly pass in the cache directory, even though it has been set in the environment. e.g.
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=227744668&repo=autoland&lineNumber=917

Comment 1

[Chris AtLee [:catlee]]

Attachment: Bug 1527118: Ensure all tests are using tooltool caches

respect TOOLTOOL_CACHE environment variable in mixin

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e7603feb2252
Ensure all tests are using tooltool caches r=aki

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/e7603feb2252