1527170 - Talos profiler markers lack some useful data

Status: RESOLVED FIXED

(Testing :: Talos, defect, P1)

Description

[Steve Fink [:sfink] [:s:]]

I've been looking at a regression in dromaeo_dom's dom-attr.html subtest. I would like to have some sort of markers to demarcate the beginning and end of the test run. (I'd like a bunch of other things too, but I'll start here.)

In eg https://perfht.ml/2I9E58T there are a whole bunch of TalosContentProfiler{Command,Response} markers. And the code looks like it should be putting the name of the test ("dom-attr") in there somewhere. But it doesn't seem to make it through. Here's an example marker:

{"start":14763.597724625,"name":"DOMEvent","dur":0.06836699999985285,"title":null,"data":{"category":"DOMEvent","docShellId":"{990330c3-7c2d-4ccb-9ea7-ded11ea0de47}","docshellHistoryId":1,"timeStamp":14763.590150625001,"interval":"start","eventType":"TalosContentProfilerCommand","type":"tracing"}}

I see that https://searchfox.org/mozilla-central/source/testing/talos/talos/talos-powers/content/TalosContentProfiler.js#230 seems to be emitting something, but in tracing through it seemed like it should have the name of the test set properly.

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

:bz as the test contact for dromaeo tests, could you comment on :sfink's request?

Comment 2

[Boris Zbarsky [:bzbarsky]]

I have no idea. I know about the actual tests, what they are measuring, etc, but not how they're hooked into the talos infrastructure, much less the profiling bits of it. Some of the webrunner stuff got hacked up a lot during the talos import, and that part I am not really familiar with....

I guess the question is what happens with the call at https://searchfox.org/mozilla-central/rev/d62176d3d70bbf9ad86a5d444f9edada52cbc2b1/testing/talos/talos/tests/dromaeo/webrunner.js#97? My understanding of the situation is that "name" there should in fact be a useful string. We should be landing there via the call at https://searchfox.org/mozilla-central/rev/d62176d3d70bbf9ad86a5d444f9edada52cbc2b1/testing/talos/talos/tests/dromaeo/tests/dom-attr.html#15 or so. Worth adding a dump() to see what's coming through?

After that point it sure seems like it should make its way to https://searchfox.org/mozilla-central/rev/d62176d3d70bbf9ad86a5d444f9edada52cbc2b1/testing/talos/talos/talos-powers/content/TalosContentProfiler.js#232 then to https://searchfox.org/mozilla-central/rev/d62176d3d70bbf9ad86a5d444f9edada52cbc2b1/testing/talos/talos/talos-powers/content/TalosContentProfiler.js#56 with data set to { marker: testname }.

Then we should land at https://searchfox.org/mozilla-central/rev/d62176d3d70bbf9ad86a5d444f9edada52cbc2b1/testing/talos/talos/talos-powers/api.js#188 and set data to that same object, right? In the "Resume" case we then pass data.marker to https://searchfox.org/mozilla-central/rev/d62176d3d70bbf9ad86a5d444f9edada52cbc2b1/testing/talos/talos/talos-powers/api.js#173 and that should do Services.profiler.AddMarker(marker).

I guess it might be worth checking (again with dump()?) whether this stuff is reached and what it passes to AddMarker?

Comment 3

[Greg Mierzwinski [:sparky]]

:kimberlythegeek, did your work on the talos profiler cover this issue?

Comment 4

[Kimberly Sereduck :kimberlythegeek]

:sparky I would have to go back and check, I will leave the needinfo open. Some of the tests were written in such a way that the test configs were just urls to be tested, using a testing library external to talos, so it wasn't straightforward how to add markers to these tests.

Comment 5

[Kimberly Sereduck :kimberlythegeek]

Attachment: Bug 1527170: Talos profiler markers lack some useful data;r?#perftest,gregtatum

add test names to dromaeo profile markers

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6a0d21e45155
Talos profiler markers lack some useful data;r=perftest-reviewers,sparky

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/6a0d21e45155