1527174 - Remove a bunch of dead code now that you can't reify ArrayBuffers underneath random typed objects

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Jeff Walden [:Waldo]]

The only way to do this is with the TypedObjectBuffer self-hosted function that isn't called anywhere. We can remove a bunch of code if we get rid of that.

Comment 1

[Jeff Walden [:Waldo]]

Attachment: Remove the unused TypedObjectBuffer self-hosted function

Comment 2

[Jeff Walden [:Waldo]]

Attachment: Remove {Inline,Outline}TransparentTypedObject::getOrCreateBuffer, needed only by the just-removed TypedObjectBuffer self-hosted function

Comment 3

[Jeff Walden [:Waldo]]

Attachment: Remove ArrayBufferObject::ArrayBufferFlags's FOR_INLINE_TYPED_OBJECT initializer, as this flag is never set when typed object buffers can't be reified

Comment 4

[Jeff Walden [:Waldo]]

Attachment: Remove ArrayBufferObject::trace as unnecessary now that buffers for inline typed objects no longer exist

Comment 5

[Steve Fink [:sfink] [:s:]]

Comment on attachment 9043168 [details] [diff] [review]
Remove the unused TypedObjectBuffer self-hosted function

Review of attachment 9043168 [details] [diff] [review]:
-----------------------------------------------------------------

Kind of sad to see this go, but go it must.

Comment 6

[Steve Fink [:sfink] [:s:]]

Comment on attachment 9043171 [details] [diff] [review]
Remove ArrayBufferObject::ArrayBufferFlags's FOR_INLINE_TYPED_OBJECT initializer, as this flag is never set when typed object buffers can't be reified

Review of attachment 9043171 [details] [diff] [review]:
-----------------------------------------------------------------

But it was all so simple and elegant, what problem could you possibly have with it? (Wow, this stuff was nasty!)

Comment 7

[Steve Fink [:sfink] [:s:]]

Comment on attachment 9043172 [details] [diff] [review]
Remove ArrayBufferObject::trace as unnecessary now that buffers for inline typed objects no longer exist

Review of attachment 9043172 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bd48f7dd71da
Remove the unused TypedObjectBuffer self-hosted function.  r=sfink
https://hg.mozilla.org/integration/mozilla-inbound/rev/b376d69fbe8f
Remove {Inline,Outline}TransparentTypedObject::getOrCreateBuffer, needed only by the just-removed TypedObjectBuffer self-hosted function.  r=sfink
https://hg.mozilla.org/integration/mozilla-inbound/rev/f21f35c4c4ec
Remove ArrayBufferObject::ArrayBufferFlags's FOR_INLINE_TYPED_OBJECT initializer, as this flag is never set when typed object buffers can't be reified.  r=sfink
https://hg.mozilla.org/integration/mozilla-inbound/rev/983e5c1a6ba7
Remove ArrayBufferObject::trace as unnecessary now that buffers for inline typed objects no longer exist.  r=sfink

Comment 9

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/bd48f7dd71da
https://hg.mozilla.org/mozilla-central/rev/b376d69fbe8f
https://hg.mozilla.org/mozilla-central/rev/f21f35c4c4ec
https://hg.mozilla.org/mozilla-central/rev/983e5c1a6ba7