Closed Bug 1527174 Opened 4 years ago Closed 4 years ago

Remove a bunch of dead code now that you can't reify ArrayBuffers underneath random typed objects

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: Waldo, Assigned: Waldo)

Details

Attachments

(4 files)

The only way to do this is with the TypedObjectBuffer self-hosted function that isn't called anywhere. We can remove a bunch of code if we get rid of that.

Attachment #9043168 - Flags: review?(jcoppeard) → review?(sphink)
Attachment #9043170 - Flags: review?(jcoppeard) → review?(sphink)
Attachment #9043172 - Flags: review?(jcoppeard) → review?(sphink)
Attachment #9043171 - Flags: review?(jcoppeard) → review?(sphink)
Comment on attachment 9043168 [details] [diff] [review]
Remove the unused TypedObjectBuffer self-hosted function

Review of attachment 9043168 [details] [diff] [review]:
-----------------------------------------------------------------

Kind of sad to see this go, but go it must.
Attachment #9043168 - Flags: review?(sphink) → review+
Attachment #9043170 - Flags: review?(sphink) → review+
Comment on attachment 9043171 [details] [diff] [review]
Remove ArrayBufferObject::ArrayBufferFlags's FOR_INLINE_TYPED_OBJECT initializer, as this flag is never set when typed object buffers can't be reified

Review of attachment 9043171 [details] [diff] [review]:
-----------------------------------------------------------------

But it was all so simple and elegant, what problem could you possibly have with it? (Wow, this stuff was nasty!)
Attachment #9043171 - Flags: review?(sphink) → review+
Comment on attachment 9043172 [details] [diff] [review]
Remove ArrayBufferObject::trace as unnecessary now that buffers for inline typed objects no longer exist

Review of attachment 9043172 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #9043172 - Flags: review?(sphink) → review+
Pushed by jwalden@mit.edu:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bd48f7dd71da
Remove the unused TypedObjectBuffer self-hosted function.  r=sfink
https://hg.mozilla.org/integration/mozilla-inbound/rev/b376d69fbe8f
Remove {Inline,Outline}TransparentTypedObject::getOrCreateBuffer, needed only by the just-removed TypedObjectBuffer self-hosted function.  r=sfink
https://hg.mozilla.org/integration/mozilla-inbound/rev/f21f35c4c4ec
Remove ArrayBufferObject::ArrayBufferFlags's FOR_INLINE_TYPED_OBJECT initializer, as this flag is never set when typed object buffers can't be reified.  r=sfink
https://hg.mozilla.org/integration/mozilla-inbound/rev/983e5c1a6ba7
Remove ArrayBufferObject::trace as unnecessary now that buffers for inline typed objects no longer exist.  r=sfink
You need to log in before you can comment on or make changes to this bug.