Closed Bug 1527176 Opened 5 years ago Closed 5 years ago

Accessibility caches can cause a parent/child cycle relationship

Categories

(GeckoView :: General, enhancement, P1)

Unspecified
All
enhancement

Tracking

(firefox67 fixed)

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: eeejay, Assigned: eeejay)

Details

Attachments

(1 file)

When using a password manager like Dashlane with a11y enabled, Firefox crashes with a stack overflow after pressing the "Enter Passcode" button in Mozilla's 2fa.

When the button is pressed the text field is shown and the button turns into a sign in button. It looks like that simultaneous tree mutation and focus change puts us in a state where the viewport cache has one hierarchy, and the focus cache has another. This causes a state where we end up in a parent/child cycle.

Pushed by eisaacson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2d0505c52681
Check each child has current parent before adding it. r=geckoview-reviewers,snorp,esawin
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: