1527184 - Optimize layout of new about:config

Status: NEW

(Firefox :: Settings UI, task, P5)

Description

[Tim Nguyen :ntim]

Taking the patch in bug 1456638 + a few more optimizations that Matt suggested in bug 1523028 comment 60 (removing the border-radius and the strips of content around the sides of the table).

Comment 1

[Tim Nguyen :ntim]

Attachment: Bug 1527184 - Optimize layout of new about:config. r=mconley

Comment 2

[Tim Nguyen :ntim]

Just a summary of what this patch does:

• Implements the header without position: sticky (removes the white flashes from the header when scrolling)
• Removes the content strips around the table as Matt suggested

Comment 3

[Matt Woodrow (:mattwoodrow)]

If this improves performance enough, then that's great, but it seems like it might not be guaranteed to work, and does change the visual styling a bit.

I'd recommend just removing the background color from the table element (and making the actual page background white, or not, the difference is super subtle), and making the table row 'odd' color opaque. That's simpler, barely visually noticeable, and worked when I tested it :)

Comment 4

[Tim Nguyen :ntim]

(In reply to Matt Woodrow (:mattwoodrow) from comment #3)

If this improves performance enough, then that's great, but it seems like it might not be guaranteed to work, and does change the visual styling a bit.

This actually does seem to reduce significantly the white flashes. I have no idea what that means in terms of measurements though, will need to check that if I or mconley have time. :)

I'd recommend just removing the background color from the table element (and making the actual page background white, or not, the difference is super subtle), and making the table row 'odd' color opaque. That's simpler, barely visually noticeable, and worked when I tested it :)

I would love to see how the layout changes alone affect performance :) I'll file another bug for the color changes.