1527258 - Right clicking Properties on “Bookmarks Toolbar” or “Other Bookmarks” from Bookmarks Menu opens a empty dialog box

Status: NEW

(Firefox :: Bookmarks & History, defect, P5)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Affected versions

• Nightly 67.0a1 (20190211215545)
• Firefox 66.0b6 (20190207161357)
• Firefox 65.0 (20190124174741)

Affected platforms

• Windows 10 x64
• Ubuntu 18.04 x64
• macOS 10.14.3

Steps to reproduce

1. Launch Firefox.
2. Add Bookmarks Menu to Toolbar (Open Menu -> Library -> Bookmarks -> Bookmarking Tools -> Add Bookmarks Menu to Toolbar).
3. Click on Show your bookmarks button from the toolbar.
4. Go to Bookmarks Toolbar or Other Bookmarks.
5. Right click one of the highlighted elements from step 4 and select Properties.

Expected result

• The “Properties” option is not available (greyed out).

Actual result

• An empty dialog box appears.
• Attached a screen recording with the issue: http://tinyurl.com/y2mx2z6f

Regression range

• First bad: bd1b6a4e5d8e1184a89ae60a74fd86d3d4a9e95c
• Last good: 67cd1ee26f2661fa5efe3d952485ab3c89af4271
• Pushlog:
  https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=67cd1ee26f2661fa5efe3d952485ab3c89af4271&tochange=bd1b6a4e5d8e1184a89ae60a74fd86d3d4a9e95c

Additional notes

• After “Properties” is clicked the following error is shown in Browser Console: “Failed to initialize dialog: Error: Cannot use an incomplete node to initialize the edit bookmark panel bookmarkProperties.js:232”.
• Right clicking either one of the options mentioned above in Library menu doesn’t show the Properties option.
• In Bookmarks Sidebar the Properties option is greyed out for both elements.
• Before the last good revision the dialog box is still displayed (Name and Description fields available) but no error is shown in browser console.

Comment 1

[Cristian Fogel [:cfogel]]

Can confirm that the issue persists on 67.0a1 (2019-02-17) - Windows 10x64.

Comment 2

[Marco Bonardo [:mak]]

This is about Properties on Other Bookmarks or Bookmarks toolbar, that is static content in the menu, likely the fake node we generate is not good enough for the dialog.

Comment 3

[Tracy Walker [:tracy]]

There are automation tests in Iris (that cover TestRail's Firefox full functional tests) under development that are running into this bug. We use the bug # here as reference for disabling the Iris tests.