1527264 - [RTL] The search engine logo is briefly displayed in the left part of the in-content "Search Bar" when it is clicked

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Marius Coman [:mcoman], Ecosystem QA]

Attachment: rec of the issue.gif

[Affected versions]:

• Firefox 66 and above

[Affected Platforms]:

• All Windows
• All Linux
• All Mac

[Prerequisites]:

• Have a Firefox AR locale build installed.

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites.
2. Open a new "Private Window".
3. Click inside the in-content "Search Bar" and observe the behavior.

[Expected result]:

• The "Search Bar is focused and the text caret is displayed.

[Actual result]:

• Also, the search engine logo is briefly displayed in the left part of the "Search Bar".

[Notes]:

• This issue is reproducible regardless of the default search engine.
• Attached a screen recording of the issue.

Comment 1

[Ricky Rosario [:rrosario, :r1cky]]

[Tracking Requested - why for this release]:

It's a tiny CSS fix for RTL users.

Comment 2

[Ricky Rosario [:rrosario, :r1cky]]

Attachment: Bug 1527264 - [RTL] The search engine logo is briefly displayed in the left part of the in-content "Search Bar" when it is clicked

MozReview-Commit-ID: FdNNX9HJI8t

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9a69e1fea9be
[RTL] The search engine logo is briefly displayed in the left part of the in-content "Search Bar" when it is clicked r=andreio

Comment 4

[Liz Henry (:lizzard) (relman/hg->git project)]

Can you request uplift? Thanks! Looks straightforward...

Comment 5

[Ricky Rosario [:rrosario, :r1cky]]

Comment on attachment 9043237 [details]
Bug 1527264 - [RTL] The search engine logo is briefly displayed in the left part of the in-content "Search Bar" when it is clicked

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

None

User impact if declined

RTL users will see the logo move when clicking on the search bar.

Is this code covered by automated tests?

No

Has the fix been verified in Nightly?

No

Needs manual test from QE?

Yes

If yes, steps to reproduce

See Comment 0

List of other uplifts needed

None

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

It's "just" 2 lines of CSS that we were missing.

String changes made/needed

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/9a69e1fea9be

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9043237 [details]
Bug 1527264 - [RTL] The search engine logo is briefly displayed in the left part of the in-content "Search Bar" when it is clicked

CSS fix, let's take it for beta 8.

Comment 8

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly AR build (67.0a1 Build ID - 20190213213409) installed, on Windows 10 x64, Arch Linux and Mac 10.13.3. Now the search engine logo remains displayed in the right part of the in-content "Search Bar".

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/e320050c6f95

Comment 10

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Beta (66.0b8 Build ID - 20190214195736) installed, on Windows 10 x64, Arch Linux and Mac 10.13.3. Now, the search engine logo remains displayed in the right part of the in-content "Search Bar".