1527315 - The print preview buttons are not entirely clickable

Status: RESOLVED DUPLICATE of bug 1525850

(Core :: Print Preview, defect, P2)

Description

[Emil Ghitta, QA [:emilghitta]]

Affected versions

• Firefox 66.0b7 (BuildId:20190211185957).
• Firefox 67.0a1 (BuildId:20190212095015).

Unaffected versions

• Firefox 65.0.1 (BuildId:20190211233335).
• Firefox 60.5.1esr (BuildId:20190211182645).

Affected platforms

• Ubuntu 18.04 64bit

Unffected platforms

• Windows 10 64bit
• macOS 10.13.6

Steps to reproduce

1. Launch Firefox.
2. Access the following link: https://cdn4.libris.ro/userdocspdf/589/faust.pdf
3. Click the “Hambruger menu”.
4. Click the “Print” option.
5. Try to click the print preview buttons (ex. “Landscape”).

Expected result

• The buttons are clickable.

Actual result

• The buttons are not entirely clickable (it seems that the button looses focus on different hover positions).

Regression range

• First bad: 1c227ac918eb1ab0b702d4424603faeb836f2b1c
• Last good: 64d38928ff5a59fb8214a0ee2472dccd6f16705d
• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=1c227ac918eb1ab0b702d4424603faeb836f2b1c&tochange=64d38928ff5a59fb8214a0ee2472dccd6f16705d
• Potential regressor: Bug 1521012

Additional notes

• In order to view a screencast with this issue, please access the following link: https://drive.google.com/file/d/1n_GBZauvZ39i_dhtl4KRMrAVH1OxUysM/view?usp=sharing

Comment 1

[Emil Ghitta, QA [:emilghitta]]

Hi Martin,

It seems that mozregression pointed out Bug 1521012 for causing this regression.

Can you please have a look?

Thank you

Comment 2

[Martin Stránský [:stransky] (ni? me)]

yes, I'll look at it.

Comment 3

[Kestrel]

The print preview mode enables the system titlebar so this the same as Bug 1525850.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

I'd like to fix it here.

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Looks like the mouse pointer position is wrongly calculated when system titlebar is turned on in CSD mode. I suspect the root window/offset is incorrectly calculated somehow, it also affects popup menus in print dialogs, those are shifted and the shift is scaled by mouse distance from left top corner. Doesn't happens in full screen more or with non-csd decorations.

Comment 6

[Martin Stránský [:stransky] (ni? me)]

The actual regression is the switch from window manager to client side decorations here at Bug 1521012.

Comment 7

[Martin Stránský [:stransky] (ni? me)]

There may be something broken at X11 level, it behaves as the mShell X window has input shape mask 12 pixels high applied on the window top but there's no mask here. The shape mask applied at Bug 1521012 is not related, it can be reproduced just with CSD mode.

Comment 8

[Kestrel]

It does not happen with mozilla.widget.use-argb-visuals defined regardless of value.

Comment 9

[Martin Stránský [:stransky] (ni? me)]

(In reply to Kestrel from comment #8)

It does not happen with mozilla.widget.use-argb-visuals defined regardless
of value.

I do see this bug with mozilla.widget.use-argb-visuals=false

Comment 10

[Kestrel]

I rechecked and it definitely does not happen for me with mozilla.widget.use-argb-visuals=false or true on Ubuntu 18.10 XWayland with latest Nightly and a new profile.

Comment 11

[Martin Stránský [:stransky] (ni? me)]

Okay, closing as dupe of bug 1525850 after all.