Closed
Bug 1527338
Opened 5 years ago
Closed 5 years ago
remove unused code from nsCMSSecureMessage.cpp
Categories
(MailNews Core :: Security: S/MIME, task)
MailNews Core
Security: S/MIME
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 67.0
People
(Reporter: KaiE, Assigned: KaiE)
Details
Attachments
(1 file)
There seems to be unused code in nsCMSSecureMessage.cpp, we should remove it.
It might have been old code, replaced by nsCMS.cpp
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
Hi Joshua, you don't seem to have a phabricator yet. Would you like to create one, or do you prefer a regular style patch for review?
|
|
Assignee | |
Comment 3•5 years ago
|
||
Jörg, this patch received r+ in phabricator.
You can get the patch from there, see "download raw diff" link, after you click the review attachment.
To test that the removal is safe, a try run is here:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=e401dca9dcf51f8071692bf5093891f303143a69
Would you like to land it?
Flags: needinfo?(jorgk)
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/944e65a17d9f
remove unused methods from nsICMSSecureMessage.idl. r=jcranmer
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
|
||
Updated•5 years ago
|
Target Milestone: --- → Thunderbird 67.0
|
||
Updated•5 years ago
|
Type: enhancement → task
You need to log in
before you can comment on or make changes to this bug.
Description
•