[wpt-sync] Sync PR 15322 - [LayoutNG] Add percentage_resolution_block_size into the min/max pass.
Categories
(Core :: CSS Parsing and Computation, enhancement, P4)
Tracking
()
Tracking | Status | |
---|---|---|
firefox67 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 15322 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/15322
Details from upstream follow.
Ian Kilpatrick <ikilpatrick@chromium.org> wrote:
[LayoutNG] Add percentage_resolution_block_size into the min/max pass.
This was surprising to me! But the min/max sizes depend on the
percentage resolution block-size, as replaced elements reflect this
size into their width.This was working previously as the replaced element was manually
computing the heights, but this adds it into the pass explicitly.This fixes it for absolute positioned objects which use the current
final height as the input to this function.Eventually we'll want to cache based off this, and record if there is
a replaced element with percentage block-size in the calculation chain.Bug: 635619
Change-Id: I6db9a90007b6c7d70f51d5ae1209ffba8a629e03
Reviewed-on: https://chromium-review.googlesource.com/c/1456203
Commit-Queue: Ian Kilpatrick \<ikilpatrick@chromium.org>
Reviewed-by: Aleks Totic \<atotic@chromium.org>
Reviewed-by: Morten Stenshorne \<mstensho@chromium.org>
Reviewed-by: Christian Biesinger \<cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631236}
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=13aef7eac9a07bc59fc68075552d08c1443ec165
Assignee | ||
Comment 2•5 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=148a85c6545f86d096d3c9da4b696947c588fe5a
Assignee | ||
Comment 3•5 years ago
|
||
Ran 6 tests PASS : 1 FAIL : 5 New tests that have failures or other problems: /css/css-sizing/intrinsic-percent-replaced-002.html: FAIL /css/css-sizing/intrinsic-percent-replaced-003.html: FAIL /css/css-sizing/intrinsic-percent-replaced-004.html: FAIL /css/css-sizing/intrinsic-percent-replaced-005.html: FAIL /css/css-sizing/intrinsic-percent-replaced-006.html: FAIL
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/403d814ff267 [wpt PR 15322] - [LayoutNG] Add percentage_resolution_block_size into the min/max pass., a=testonly https://hg.mozilla.org/integration/mozilla-inbound/rev/3b96582a3422 [wpt PR 15322] - Update wpt metadata, a=testonly
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/2d9ecd8d27b6 [wpt PR 15322] - [LayoutNG] Add percentage_resolution_block_size into the min/max pass., a=testonly https://hg.mozilla.org/integration/mozilla-inbound/rev/0bef32a92a04 [wpt PR 15322] - Update wpt metadata, a=testonly
Comment 6•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2d9ecd8d27b6
https://hg.mozilla.org/mozilla-central/rev/0bef32a92a04
Description
•