[wpt-sync] Sync PR 15344 - [Animation Worklet] Clean up animator registration logic for wpt test

RESOLVED FIXED in Firefox 67

Status

enhancement
P4
normal
RESOLVED FIXED
3 months ago
2 months ago

People

(Reporter: wptsync, Unassigned)

Tracking

unspecified
mozilla67
Points:
---

Firefox Tracking Flags

(firefox67 fixed)

Details

(Whiteboard: [wptsync downstream], )

Assignee

Description

3 months ago

Sync web-platform-tests PR 15344 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/15344
Details from upstream follow.

Yi Gu <yigu@chromium.org> wrote:

[Animation Worklet] Clean up animator registration logic for wpt test

Similar to [1], we should register the animator only once in the setup
for test current-time.https.html.

Given that DocumentTimeline does not always move forward, this test
also replaces waitForNextFrame with waitForDocumentTimelineAdvance.

[1] https://cs.chromium.org/chromium/src/third_party/blink/web_tests/external/wpt/animation-worklet/scroll-timeline-writing-modes.https.html

Bug: 923881
Change-Id: Iabc6c7c1cea520e3dd81ed8a781cc072e2d8e20b
Reviewed-on: https://chromium-review.googlesource.com/c/1466145
Commit-Queue: Yi Gu \<yigu@chromium.org>
Reviewed-by: Majid Valipour \<majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631287}

Assignee

Comment 3

3 months ago
Ran 1 tests
ERROR  : 1

Existing tests that now have a worse result (e.g. they used to PASS and now FAIL):
/animation-worklet/current-time.https.html: ERROR

Comment 4

2 months ago
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/07cdbdb2c608
[wpt PR 15344] - [Animation Worklet] Clean up animator registration logic for wpt test, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/c746aaf82c65
[wpt PR 15344] - Update wpt metadata, a=testonly

Comment 5

2 months ago
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6aeb4c5cd8eb
[wpt PR 15344] - [Animation Worklet] Clean up animator registration logic for wpt test, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/edd5fd41dac0
[wpt PR 15344] - Update wpt metadata, a=testonly

Comment 6

2 months ago
bugherder
Status: NEW → RESOLVED
Last Resolved: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.