1527495 - Migrate text-link to CE

Status: RESOLVED FIXED

(Toolkit :: XUL Widgets, task)

Description

[alexander :surkov (:asurkov)]

splitting bug 1448213 into two as Brian suggests

Comment 1

[alexander :surkov (:asurkov)]

Attachment: Bug 1527495 - migrate text-link binding to CE, r=bgrins

Comment 2

[alexander :surkov (:asurkov)]

here's talos results https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=fcabe2c9c7112039efe5a1ce22f61775078021b9&newProject=try&newRevision=d11adc7288c87350529de747fff3f63980be77a3&framework=1&showOnlyImportant=1

Comment 3

[Brian Grinstead [:bgrins]]

Jorg, this is going to need updates on the TB side as well: https://searchfox.org/comm-central/search?q=text-link&path=. Elements that have <label class="text-link"> will need to become <label is="text-link"> and JS callers will need to do document.createXULElement("label", {is: "text-link"}); instead of let l = document.createXULElement("label"); l.className = "text-link";.

See https://phabricator.services.mozilla.com/D19595 for example changes.

Comment 4

[Jorg K (CEST = GMT+2)]

Thanks, Magnus, Richard, please take care of this.

Comment 5

[Richard Marti (:Paenglab)]

I was already CCed to this bug and planned to port it. I'll do it today.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5b7bdfe0b357
migrate text-link binding to CE, r=bgrins

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/5b7bdfe0b357

Comment 8

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4796