Avoid drawing each picture cache tile separately

RESOLVED FIXED in Firefox 67

Status

()

enhancement
RESOLVED FIXED
4 months ago
3 months ago

People

(Reporter: kvark, Assigned: kvark)

Tracking

unspecified
mozilla67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

Assignee

Description

4 months ago

I noticed that currently when picture caching is used, every 1024x256 tile turns to be a separate draw call with a dedicated texture. This consumes a fair chunk of CPU time, given that we have roughly 100 draw calls in the budget.

Assignee

Updated

4 months ago
Assignee: nobody → dmalyshau
Status: NEW → ASSIGNED
Assignee

Comment 1

4 months ago

this change reduces the number of draw calls on a new page from 141 to 104.

Assignee

Comment 2

4 months ago

This is a preparatory change that can be useful by itself:

  • use match on EntryKind to allow safe expansion
  • avoid code duplication in get()
  • fix some comments
Assignee

Updated

4 months ago
Keywords: leave-open
Assignee

Comment 3

4 months ago

Manage the texture space for picture tiles separately inside the texture cache.

Comment 4

4 months ago
Pushed by dmalyshau@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/84d60f483f42
WR texture cache code cleanup r=jrmuizel
Attachment #9043452 - Attachment is obsolete: true

Comment 6

4 months ago
Pushed by dmalyshau@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f2b5a9d987e8
Separate picture texture cache r=gw
Assignee

Updated

4 months ago
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Keywords: leave-open
Resolution: --- → FIXED
Depends on: 1528820
Target Milestone: --- → mozilla67
No longer depends on: 1528674
Regressions: 1528674
You need to log in before you can comment on or make changes to this bug.