Open Bug 1527527 Opened 6 years ago Updated 2 years ago

Context menu items in about:devtools-toolbox should set from ContextMenuChild

Categories

(DevTools :: about:debugging, enhancement, P3)

Product:
DevTools
Component:
about:debugging
Type:
enhancement

Tracking

(Not tracked)

People

(Reporter: daisuke, Unassigned)

Details

This is a follow up to bug 1522400.

In the implementation of bug 1522400, nsContextMenu[1] determins the visibility and so on of some context menu items by a flag which indicates whether about:devtools-toolbox which is provided by ContextMenuChild[2].
However, it is ideal that ContextMenuChild determins all the items and nsContextMenu simply builds the context menu along this data.
And please see Julian's suggestion at [3] as concrete ideas.

[1] https://searchfox.org/mozilla-central/source/browser/actors/ContextMenuChild.jsm
[2] https://searchfox.org/mozilla-central/source/browser/base/content/nsContextMenu.js
[3] https://phabricator.services.mozilla.com/D17459#502722

This bug is a general cleanup to move most of the logic to ContextMenuChild, not only related to remote-debugging items.

No longer blocks: remote-debugging-ng
Severity: normal → enhancement
Component: about:debugging → General
Priority: -- → P3
Product: DevTools → Firefox
Summary: [remote-dbg-next] Context menu items in about:devtools-toolbox should set from ContextMenuChild → Context menu items in about:devtools-toolbox should set from ContextMenuChild

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Component: General → about:debugging
Product: Firefox → DevTools
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.