Closed Bug 152756 Opened 22 years ago Closed 22 years ago

Add & implement imgIContainer::ResetAnimation

Categories

(Core :: Graphics: ImageLib, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.3alpha

People

(Reporter: paper, Assigned: paper)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

ResetAnimation, or starting from frame 0 again, is needed for various functions
in Mozilla (reloading page/image and setting image.src are two that come to mind).

StopAnimation and StartAnimation do not reset the animation to the beginning.
One could reset the animation on StopAnimation, but this would break backwards
compatibility and remove the "feature" of pausing an animation.
Adding Dependencies/Blockers.

While Bug 77497 is not a true blocker, I'm not going to put a patch up until
it's fixed. (because it would cause bit rot)
Status: UNCONFIRMED → NEW
Depends on: 77497
Ever confirmed: true
Target Milestone: --- → mozilla1.1beta
retargetting, adding more bugs that this one theoritically blocks, and some
general evil glaring at the blocker.
Blocks: 69405, 100909
Target Milestone: mozilla1.1beta → mozilla1.2alpha
Blocker has moved to future.. thus fix will sit on my computer until the blocker
gets fixed.
Target Milestone: mozilla1.2alpha → Future
Attached patch ResetAnimation (obsolete) — Splinter Review
diff with a -5 in hopes I don't need to unbitrot (multiple imgContainerGIF are
awaiting in bugs)

Side Notes: imgContainerART in the Netscape code is going to also need a
ResetAnimation
Keywords: patch, review
Target Milestone: Future → mozilla1.3alpha
Attached patch ResetAnimationSplinter Review
1) Disallow ResetAnimation after user has stopped animation (kDontAnimMode)
2) moved ResetAnimation call to better spot

This patch should fix all dependants except Bug 69405.
Attachment #102116 - Attachment is obsolete: true
Comment on attachment 102118 [details] [diff] [review]
ResetAnimation

r=pavlov
Attachment #102118 - Flags: review+
Comment on attachment 102118 [details] [diff] [review]
ResetAnimation

sr=tor
Attachment #102118 - Flags: superreview+
Comment on attachment 102118 [details] [diff] [review]
ResetAnimation

a=asa for checkin to 1.2beta (on behalf of drivers)
Attachment #102118 - Flags: approval+
Checked In 10/09/2002 21:43
Blocks: 107815
Build 2002101010 -> Fixed
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: