Closed Bug 1527614 Opened 7 months ago Closed 7 months ago

Fix a couple of missing assertions in TelemetryTestUtils.jsm

Categories

(Toolkit :: Telemetry, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: standard8, Assigned: standard8)

Details

Attachments

(1 file)

In working on another bug, I noticed a couple of issues:

  • TelemetryTestUtils.assertHistogram doesn't actually check the item at the given index exists, and therefore may fail to notice it is missing.
  • TelemetryTestUtils.assertKeyedHistogramValue throws an error that snapshot[key] is undefined, when it could provide a nice error message.
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/53d7d4732ab9
Fix a couple of missing assertions in TelemetryTestUtils.jsm. r=chutten
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.