Port bug 1506102: English is available in the main dropdown but only applies to Fluent elements

RESOLVED FIXED in Thunderbird 67.0

Status

defect
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 67.0

Thunderbird Tracking Flags

(thunderbird66 fixed, thunderbird67 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Assignee

Description

3 months ago

From bug 1506102:

Simple scenario: take an Italian build and enable intl.multilingual.enabled

At this point English ("Inglese (Stati Uniti)") will be available in the dropdown, but it can only translate Fluent parts without a language pack.

Assignee

Comment 1

3 months ago

Port of https://hg.mozilla.org/mozilla-central/rev/0379792adfbb. Slightly different because we haven't implemented the downloadable dictionaries.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9043643 - Flags: review?(jorgk)

Comment 2

3 months ago
Comment on attachment 9043643 [details] [diff] [review]
1527653-lastFallbackLocale.patch

Review of attachment 9043643 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Richard Marti (:Paenglab) from comment #1)
> Slightly different because we haven't implemented the downloadable dictionaries.

Where is the difference?

::: mail/components/preferences/preferences.js
@@ +151,5 @@
> +  let {availableLocales, defaultLocale, lastFallbackLocale} = Services.locale;
> +  // If defaultLocale isn't lastFallbackLocale, then we still need the langpack
> +  // for lastFallbackLocale for it to be useful.
> +  if (defaultLocale != lastFallbackLocale) {
> +    let lastFallbackId = `langpack-${lastFallbackLocale}@firefox.mozilla.org`;

Does this make sense for TB?
Assignee

Comment 3

3 months ago

(In reply to Jorg K (GMT+1) from comment #2)

Comment on attachment 9043643 [details] [diff] [review]
1527653-lastFallbackLocale.patch

Review of attachment 9043643 [details] [diff] [review]:

(In reply to Richard Marti (:Paenglab) from comment #1)

Slightly different because we haven't implemented the downloadable dictionaries.

Where is the difference?

https://hg.mozilla.org/mozilla-central/rev/0379792adfbb#l1.144 to 159.

::: mail/components/preferences/preferences.js
@@ +151,5 @@

  • let {availableLocales, defaultLocale, lastFallbackLocale} = Services.locale;
  • // If defaultLocale isn't lastFallbackLocale, then we still need the langpack
  • // for lastFallbackLocale for it to be useful.
  • if (defaultLocale != lastFallbackLocale) {
  • let lastFallbackId = langpack-${lastFallbackLocale}@firefox.mozilla.org;

Does this make sense for TB?

Changed to langpack-${lastFallbackLocale}@thunderbird.mozilla.org

Attachment #9043643 - Attachment is obsolete: true
Attachment #9043643 - Flags: review?(jorgk)
Attachment #9044690 - Flags: review?(jorgk)

Comment 4

3 months ago

What actually happens to this variable? What is thunderbird.mozilla.org? If anything, it should be something@thunderbird.net. If in doubt, ask Andrei/Sancus.

Assignee

Comment 5

3 months ago

(In reply to Jorg K (GMT+1) from comment #4)

What actually happens to this variable? What is thunderbird.mozilla.org? If anything, it should be something@thunderbird.net. If in doubt, ask Andrei/Sancus.

It has to be thunderbird.mozilla.org because the language packs are have the ID like "langpack-de@thunderbird.mozilla.org" for the German language pack. This name is automatically created during the build of the language packs.

Comment 6

3 months ago
Attachment #9044690 - Attachment is obsolete: true
Attachment #9044690 - Flags: review?(jorgk)
Attachment #9044725 - Flags: feedback?(richard.marti)
Assignee

Comment 7

3 months ago
Comment on attachment 9044725 [details] [diff] [review]
1527653-lastFallbackLocale.patch (JK)

I see no difference in the UI. But is good to apply a part of the langpack/dictionary import when we don't know if we support this in the future (see bug 1487315)?

I can be also totally wrong and we need this part.
Attachment #9044725 - Flags: feedback?(richard.marti) → feedback+

Comment 8

3 months ago

I don't understand the question. All I did was reshuffle the existing code and split it into three functions like M-C have it. No code was added and no behaviour was changed. Can you see that? What "this part" are you referring to?

Assignee

Comment 9

3 months ago

With "this part" is your addition, or reshuffle meant.

Comment 10

3 months ago

Hmm, I reshuffled it purely to be in sync with M-C.

Updated

3 months ago
Attachment #9044725 - Flags: review+

Comment 11

3 months ago

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/d332fd6631c9
Port bug 1506102: Don't count lastFallbackLocale as installed when just fluent is included. r=jorgk DONTBUILD

Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → FIXED

Updated

3 months ago
Target Milestone: --- → Thunderbird 67.0

Comment 12

3 months ago
Comment on attachment 9044725 [details] [diff] [review]
1527653-lastFallbackLocale.patch (JK)

We can take this to beta like FF did.
Attachment #9044725 - Flags: approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.