Closed Bug 1527671 Opened 7 months ago Closed 7 months ago

Position information for arrow function bytecodes is off by one token

Categories

(DevTools :: Debugger, defect, P2)

defect

Tracking

(firefox67 fixed)

RESOLVED FIXED
Firefox 67
Tracking Status
firefox67 --- fixed

People

(Reporter: loganfsmyth, Assigned: loganfsmyth)

References

Details

Attachments

(1 file)

If you look at the position information for the bytecodes of arrow functions, you'll see that they show up as

var foo = () => {};
//      ^     - current
//        ^   - desired

This position ends up being used for source notes in some cases now, meaning that this can
cause breakpoints to be given the wrong position when assigned to a variable. This fixes
that by using the correct token for the position value.

Pushed by lsmyth@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/185be874d4a6
Assign the correct start position to arrow functions. r=arai,jorendorff
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.