1527691 - Can tab into disabled inputs

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect)

Description

[scottaohara]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:65.0) Gecko/20100101 Firefox/65.0

Steps to reproduce:

When using 65.0 (mac and PC) certain disabled form controls can unexpectedly receive keyboard focus.

• Go to: https://codepen.io/scottohara/pen/RvBEBO
• Focus the first text field and use the tab key to navigate the form controls

Actual results:

For inputs such as type=time or type=date, focus still enters the sub-fields of these inputs, even though the input element has the disabled attribute.

Expected results:

Focus should not have entered the disabled inputs and instead followed the focus order of:

1. text field
2. focus test 1 button
3. focus test 2 button
4. focus test 3 button

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Number (bug 1368087) works now since that is just a text input, but date/datetime doesn't. I can take a look.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Test-case from reporter.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1527691 - Disabled datetimebox inner elements shouldn't be tabbable. r=Gijs

They're not focusable with mouse already.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8f2ec80adf9a
Disabled datetimebox inner elements shouldn't be tabbable. r=Gijs

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/8f2ec80adf9a

Comment 9

[Oana Botisan, Desktop QA]

Managed to reproduce the issue on an older version of Nightly (2019-02-13) using macOS 10.15.
Retested everything on the same platform using Firefox 102.0b3 and Nightly 103.0a1. The issue is not reproducing anymore.