1527707 - Port bug 1524264: Move "No Proxy for" outside the radio button and change the case for design guildline

Status: RESOLVED FIXED

(Thunderbird :: Preferences, task)

Description

[Richard Marti (:Paenglab)]

Bug 1524264 moved the noproxy field out of the radio section to be accessible also when the manual proxy config option is disabled.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1527707-move-noproxy.patch

This is a port of https://hg.mozilla.org/integration/autoland/rev/6e651b1b00b1

Additionally I changed some options "disabled" logic to be in sync with FX.

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9043699 [details] [diff] [review]
1527707-move-noproxy.patch

Review of attachment 9043699 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin

Comment 3

[Jorg K (CEST = GMT+2)]

Comment on attachment 9043699 [details] [diff] [review]
1527707-move-noproxy.patch

Review of attachment 9043699 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/locales/en-US/chrome/messenger/preferences/connection.dtd
@@ +34,5 @@
>  <!ENTITY  SSLport.label                 "Port:">
>  <!ENTITY  SSLport.accesskey             "o">
>  <!ENTITY  SOCKSport.label               "Port:">
>  <!ENTITY  SOCKSport.accesskey           "t">
> +<!ENTITY  noproxy2.label                "No proxy for:">

Why does that need an ID change?

Comment 4

[Richard Marti (:Paenglab)]

(In reply to Jorg K (GMT+1) from comment #3)

Comment on attachment 9043699 [details] [diff] [review]
1527707-move-noproxy.patch

Review of attachment 9043699 [details] [diff] [review]:

::: mail/locales/en-US/chrome/messenger/preferences/connection.dtd
@@ +34,5 @@

<!ENTITY SSLport.label "Port:">
<!ENTITY SSLport.accesskey "o">
<!ENTITY SOCKSport.label "Port:">
<!ENTITY SOCKSport.accesskey "t">
+<!ENTITY noproxy2.label "No proxy for:">

Why does that need an ID change?

It's a change from Proxy to proxy to be the same as the other radio labels. The upper case P is only inside the "Manual proxy configuration" block

Comment 5

[Jorg K (CEST = GMT+2)]

Localisers don't care about capitalisation. Pleas drop this.

Comment 6

[Richard Marti (:Paenglab)]

Attachment: 1527707-move-noproxy.patch

Without entity name change.

Comment 7

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/44846ace529b19e83c8734c3de0cafc51978aa4e
Port bug 1524264: move noproxy textbox lower to hint as a global effect. r=mkmelin