Closed Bug 1527769 Opened 6 months ago Closed 6 months ago

RKV XPCOM interface introduced many warnings "method should have snake case name"

Categories

(Toolkit :: General, enhancement, P3, minor)

enhancement

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: mythmon, Assigned: mythmon)

References

Details

Attachments

(1 file)

In bug 1490496, an XPCOM API to RKV was added, and with it a lot of rust warnings like this:

 0:40.01 warning: method `GetValue` should have a snake case name
 0:40.02    --> toolkit/components/kvstore/src/lib.rs:324:32
 0:40.02     |
 0:40.02 324 |     xpcom_method!(get_value => GetValue() -> *const nsIVariant);
 0:40.02     |                                ^^^^^^^^ help: convert the identifier to snake case: `get_value`

I think that the CamelCase names are going to be a part of the XPCOM interface no matter what, so we should silence these warnings for the xpcom_method! macro.

Assignee: nobody → mcooper
Status: NEW → ASSIGNED
Pushed by mcooper@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ff158458cf30
Silence snake case name warning for Rust implemented XPCOM methods r=froydnj
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.