1527769 - RKV XPCOM interface introduced many warnings "method should have snake case name"

Status: RESOLVED FIXED

(Toolkit :: General, enhancement, P3)

Description

[Michael Cooper [:mythmon]]

In bug 1490496, an XPCOM API to RKV was added, and with it a lot of rust warnings like this:

 0:40.01 warning: method `GetValue` should have a snake case name
 0:40.02    --> toolkit/components/kvstore/src/lib.rs:324:32
 0:40.02     |
 0:40.02 324 |     xpcom_method!(get_value => GetValue() -> *const nsIVariant);
 0:40.02     |                                ^^^^^^^^ help: convert the identifier to snake case: `get_value`

I think that the CamelCase names are going to be a part of the XPCOM interface no matter what, so we should silence these warnings for the xpcom_method! macro.

Comment 1

[Michael Cooper [:mythmon]]

Attachment: Bug 1527769 - Silence snake case name warning for Rust implemented XPCOM methods r?myk!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff158458cf30
Silence snake case name warning for Rust implemented XPCOM methods r=froydnj

Comment 3

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/ff158458cf30