Closed Bug 1527776 Opened 6 years ago Closed 5 years ago

Feature gates shouldn't overwrite existing values on the default branch

Categories

(Toolkit :: FeatureGate, enhancement, P3)

Product:
Toolkit
Component:
FeatureGate
Type:
enhancement

Tracking

()

Status:
RESOLVED INVALID

People

(Reporter: mythmon, Unassigned)

Details

Feature gates currently writes the built-in default of the pref to the default branch immediately on every startup. This could result in a race condition where it overrides other systems writing to the default branch, such as Normandy.

Feature gates should only write to the default branch if the preference doesn't already have a value.

Assignee: nobody → mcooper
Status: NEW → ASSIGNED

mythmon, is this something you can pick back up?

Flags: needinfo?(mcooper)
Priority: P1 → P3

Resetting back to unassigned, I'm not currently working on any feature gates tasks. I don't think I'll have time for this in the near future.

That being said, I don't believe this is still an issue. I'm not sure when it changed, but I don't see any code that sets preferences in the Feature Gate code: https://searchfox.org/mozilla-central/search?q=setBoolPref&case=false&regexp=false&path=toolkit%2Fcomponents%2Ffeaturegates

Assignee: mcooper → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(mcooper)

Thanks, I also don't see anything that sets prefs (boolean or otherwise) so I'll close this bug as Invalid.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.