1527796 - Support artifact build on windows, not WSL

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, enhancement, P5)

Description

[Makoto Kato [:m_kato]]

Full build will need a lot of hacks to use clang (not clang-cl) if using Windows since we have to compile host binaries. But artifact build doesn't need C/C++ compiler. So we can support artifact build of Android on Windows.

Comment 1

[Makoto Kato [:m_kato]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=eec3270eeffe2439a752a3b7226827e9b7d8c662

Comment 2

[Makoto Kato [:m_kato]]

Attachment: Bug 1527796 - Part 1. Add python.exe path to call mach shell script from python. r=nalexander

Since Windows doesn't call mach command from MSYS shell, we need python path
to call mach.

Comment 3

[Makoto Kato [:m_kato]]

Attachment: Bug 1527796 - Part 2. Detect Java on Windows. r=nalexander

When installing JDK 1.8, it writes path to the following registry.

HKEY_LOCAL_MACHINE\SOFTWARE\JavaSoft\Java Development Kit\1.8\JavaHome

So we use this registry to detect JDK installation path on Windows if available.

Depends on D20448

Comment 4

[Makoto Kato [:m_kato]]

Attachment: Bug 1527796 - Part 3. Use gradlew.bat on Windows. r=nalexander

There is gradlew.bat to run gradle on Windows, so we should use it.

Depends on D20449

Comment 5

[Makoto Kato [:m_kato]]

Attachment: Bug 1527796 - Part 4. Convert file separator to slash. r=nalexander

The file separator of Windows is backslash, not slash. So we have to convert
it to slash if necessary.

Depends on D20451

Comment 6

[Makoto Kato [:m_kato]]

Attachment: Bug 1527796 - Part 5. Add python.exe path of mozilla-build to call mach command from gradle. r=nalexander

Since gradle doesn't run on sh.exe, it requires python path to run mach command . But gradle doesn't have a way to detect python.exe.

When using MozillaBuild, it sets MOZILLABUILD environment value, so we can
detect python path in MozillaBuild using it if available.

Depends on D20453

Comment 7

[Makoto Kato [:m_kato]]

Attachment: Bug 1527796 - Part 6. Update test_checks_configure.py since java_search_paths requries host. r?nalexander

Since we add host parameter to java_search_paths, test_java_tool_checks is always failure due to no host function. So I need to set dummy host function.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c95084270844
Part 1. Add python.exe path to call mach shell script from python. r=nalexander
https://hg.mozilla.org/integration/mozilla-inbound/rev/440350958e77
Part 2. Detect Java on Windows. r=nalexander,glandium
https://hg.mozilla.org/integration/mozilla-inbound/rev/230ed445be2c
Part 3. Use gradlew.bat on Windows. r=nalexander
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f50c0fa29d8
Part 4. Convert file separator to slash. r=nalexander
https://hg.mozilla.org/integration/mozilla-inbound/rev/b698ba8b6e24
Part 5. Add python.exe path of mozilla-build to call mach command from gradle. r=nalexander
https://hg.mozilla.org/integration/mozilla-inbound/rev/6e20e4acf4e5
Part 6. Update test_checkes_configure.py since java_search_paths requries host. r=nalexander

Comment 9

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/c95084270844
https://hg.mozilla.org/mozilla-central/rev/440350958e77
https://hg.mozilla.org/mozilla-central/rev/230ed445be2c
https://hg.mozilla.org/mozilla-central/rev/3f50c0fa29d8
https://hg.mozilla.org/mozilla-central/rev/b698ba8b6e24
https://hg.mozilla.org/mozilla-central/rev/6e20e4acf4e5