1527824 - SelectorCard should use PushModel rather than its own implementation

Status: RESOLVED FIXED

(Tree Management :: Perfherder, enhancement, P1)

Description

[Ed Morley [:emorley]]

I noticed that ui/perfherder/SelectorCard.jsx manually handles fetching pushes here:
https://github.com/mozilla/treeherder/blob/8e88941f74bf62b8b11c212b52aa3873c0891711/ui/perfherder/SelectorCard.jsx#L68-L84

When it could use PushModel instead:
https://github.com/mozilla/treeherder/blob/8e88941f74bf62b8b11c212b52aa3873c0891711/ui/models/push.js

Comment 1

[Sarah Clements [:sclements]]

It was initially using the resultset endpoint, which was changed to push here: https://github.com/mozilla/treeherder/pull/4514/commits/102a3847bcf4771acd4181c6399ebcf7e21ac9e9.

The Push Model's fetch isn't currently using the getData method (or some other alternative) per Bug 1473777 so that should be addressed as part of the switch.

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/4713

Comment 3

[Sarah Clements [:sclements]]

This has landed: https://github.com/mozilla/treeherder/commit/7245a93d32ef974a06058cacb63925688c76f99d