Closed Bug 1527850 Opened 5 years ago Closed 5 years ago

Null out CompartmentPrivate's scope pointer when moving XPCWrappedNativeScope to the dying scopes list

Categories

(Core :: XPConnect, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: jandem, Assigned: jandem)

Details

Attachments

(1 file)

XPCWrappedNativeScope and CompartmentPrivate are both per-compartment, but their lifetimes are subtly different. Nulling out compartment->scope when the scope is about to die is simple to do, green on Try and might prevent issues in the future.

Pushed by jdemooij@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7fa26c15865b
Null out CompartmentPrivate's scope pointer when moving XPCWrappedNativeScope to the dying scopes list. r=bzbarsky
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: