BlackConnect won't build on Linux

RESOLVED FIXED

Status

Core Graveyard
Java to XPCOM Bridge
P3
normal
RESOLVED FIXED
19 years ago
3 years ago

People

(Reporter: Frank Mitchell, Assigned: Frank Mitchell)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Assignee)

Description

19 years ago
The original e-mail message:

------------------------------

Subject:
         building java-xpcom bridge on linux
    Date:
         Thu, 30 Sep 1999 02:40:23 -0400 (EDT)
   From:
         pstoll@bellatlantic.net
     To:
         frankm@eng.sun.com, drapeau@eng.sun.com




Greetings,

I'm planning on tinkering with the java/mozilla-xpcom bridge. In getting
setup, I ran into some problems and I thought I'd pass the info back to
you. Attached are some small changes I had to make to get it to build and
run the tests. FYI, I'm running on RH Linux 6.0 x86, using egcs-2.91.66,
with the blackdown jdk1.2pre2-v2.

Also, is there a news group you use regularly? I looked at
netscape.public.mozilla.java, but it seemed to focus on jazilla more than
blackwood. Also, is there a better way to get changes back to you?

Regards,
  Perry
  perry.stoll@mail.com

********************

Invalid syntax because there is a missing \ at the end of the
ALL_TRASH definition.

Change mozilla/config/rules.mk line 181:

                          _gen _jmc _jri _stubs $(MDDEPDIR) \
                          $(wildcard gts_tmp_*) $(PROGOBJS)
                          $(wildcard $(JAVA_DESTPATH)/$(PACKAGE)/*.class)
to:
                          _gen _jmc _jri _stubs $(MDDEPDIR) \
                          $(wildcard gts_tmp_*) $(PROGOBJS) \
                          $(wildcard $(JAVA_DESTPATH)/$(PACKAGE)/*.class)

********************

failed to compile because it hadn't seen a definition for optarg or
optind. Might need to put this under an #ifdef HAVE_GETOPT_H and add the
appropriate check to the configure script.

added the following at line 30 of mozilla/java/xpcom/tools/genproxy.c:

#include <getopt.h>

********************

There is an unused argument to the printf in
mozilla/java/xpcom/tools/genproxy.c, line 353:

change:
        fprintf(out,  " {\n", ide->name);
to:
        fprintf(out,  " {\n");

********************

In a few places, should not use the name "jarray" as an argument
name. it shadows the global typedef jarray in jni.h. Here's a patch:

RCS file: /cvsroot/mozilla/java/xpcom/src/xpjava.cpp,v
retrieving revision 1.5
diff -r1.5 xpjava.cpp
383c383
<                               const jobjectArray jarray) {
---
>                               const jobjectArray theJarray) {
387c387
<         jobject elem = env->GetObjectArrayElement(jarray, i);
---
>         jobject elem = env->GetObjectArrayElement(theJarray, i);
506c506
<                               jobjectArray jarray,
---
>                               jobjectArray theJarray,
512c512
<         jobject elem = NULL; // env->GetObjectArrayElement(jarray, i);
---
>         jobject elem = NULL; // env->GetObjectArrayElement(theJarray, i);
538c538
<         env->SetObjectArrayElement(jarray, i, elem);
---
>         env->SetObjectArrayElement(theJarray, i, elem);


********************

non-void function reaches end without a return statement:

Add return to method jboolean xpjd_GetInterfaceInfoNative(), line 750:

        return JNI_TRUE;


********************

failed to compile because method signature in implementation doesn't
match IDL defintion:

change mozilla/java/xpcom/test/JSSample.cpp, line 193;

NS_IMETHODIMP JSSample::SetSomeName(char * aSomeName) {

to:

NS_IMETHODIMP JSSample::SetSomeName(const char * aSomeName) {

********************

in mozilla/java/xpcom/README, under the Build instructions, #3 says to
run gmake as:

        gmake JAVAC="javac -g -d $MOZILLA_FIVE_HOME/../classes"
                                                   ^^^^
I think it should be

        gmake JAVAC="javac -g -d $MOZILLA_FIVE_HOME/dist/classes"
(Assignee)

Updated

19 years ago
Status: NEW → ASSIGNED
(Assignee)

Updated

19 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 19 years ago
Resolution: --- → FIXED
(Assignee)

Comment 1

19 years ago
Fixed
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.