Closed Bug 1527946 Opened 1 year ago Closed 1 year ago

QuantumBar: Input value doesn't update when cycling through results until no result is selected

Categories

(Firefox :: Address Bar, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 67
Tracking Status
firefox67 --- fixed

People

(Reporter: standard8, Assigned: dao)

References

Details

Attachments

(1 file)

Some of the tests in browser_urlbarOneOffs.js are failing because gURLBar.textValue is not the empty string.

This might be intentional, but either way we should fix up the test to match what we want.

Priority: -- → P2

browser_urlbarOneOffs_searchSuggestions.js may also need fixing due to this.

Depends on: 1527940

The patch in bug 1528430 fixes this for browser_urlbarOneOffs_searchSuggestions.js but not browser_urlbarOneOffs.js, and I don't know why right now.

Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Blocks: 1527260
Summary: QuantumBar: Work out differences with "textValue" tests failing when cycling through one-off buttons → QuantumBar: Input value doesn't update when cycling through results until no result is selected
Attachment #9049260 - Attachment description: Bug 1527946 - QuantumBar: Input value doesn't update when cycling through results until no result is selected. r=Standard8 → Bug 1527946 - QuantumBar: Update the input value when cycling through results until no result is selected. r=Standard8
Blocks: 1533766
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/34a3d6b4f10f
QuantumBar: Update the input value when cycling through results until no result is selected. r=Standard8
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.