QuantumBar: Input value doesn't update when cycling through results until no result is selected

RESOLVED FIXED in Firefox 67

Status

()

enhancement
P2
normal
RESOLVED FIXED
4 months ago
3 months ago

People

(Reporter: standard8, Assigned: dao)

Tracking

(Blocks 2 bugs)

unspecified
Firefox 67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

Reporter

Description

4 months ago

Some of the tests in browser_urlbarOneOffs.js are failing because gURLBar.textValue is not the empty string.

This might be intentional, but either way we should fix up the test to match what we want.

Assignee

Updated

4 months ago
Priority: -- → P2
Reporter

Comment 1

4 months ago

browser_urlbarOneOffs_searchSuggestions.js may also need fixing due to this.

Reporter

Updated

4 months ago
Depends on: 1527940

The patch in bug 1528430 fixes this for browser_urlbarOneOffs_searchSuggestions.js but not browser_urlbarOneOffs.js, and I don't know why right now.

Assignee

Updated

3 months ago
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Assignee

Updated

3 months ago
Blocks: 1527260
Assignee

Updated

3 months ago
Summary: QuantumBar: Work out differences with "textValue" tests failing when cycling through one-off buttons → QuantumBar: Input value doesn't update when cycling through results until no result is selected
Attachment #9049260 - Attachment description: Bug 1527946 - QuantumBar: Input value doesn't update when cycling through results until no result is selected. r=Standard8 → Bug 1527946 - QuantumBar: Update the input value when cycling through results until no result is selected. r=Standard8
Reporter

Updated

3 months ago
Blocks: 1533766

Comment 4

3 months ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/34a3d6b4f10f
QuantumBar: Update the input value when cycling through results until no result is selected. r=Standard8

Comment 5

3 months ago
bugherder
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.