QuantumBar: Moving selection to one-off search buttons doesn't update the "Search with" action text
Categories
(Firefox :: Address Bar, defect, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: standard8, Assigned: adw)
References
Details
(Whiteboard: [fxsearch])
Attachments
(1 file)
STR:
- Start typing in the urlbar with something that will result in the first item being "Search with <engine>"
- Press alt + arrow down.
- As you then navigate through the one-off buttons, observe the "Search with" text.
Expected Results
=> "Search with <engine>" is updated as the one-off button changes.
Actual Results
=> The text is not updated.
This currently causes part of browser_urlbarOneOffs.js to fail.
|
Assignee | |
Comment 2•5 years ago
|
||
Copying my comment from bug 1528408:
For the awesomebar, it's handled here: https://searchfox.org/mozilla-central/rev/8e8ccec700159dc4efe061cfec2af10b21a8e62a/browser/base/content/urlbarBindings.xml#2642
Not directly related to this bug, but we need to listen for one-off selection changes to properly implement search alias highlighting too.
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 3•5 years ago
|
||
|
|
Assignee | |
Comment 4•5 years ago
|
||
(In reply to Drew Willcoxon :adw from comment #2)
Not directly related to this bug, but we need to listen for one-off
selection changes to properly implement search alias highlighting too.
Actually we should be hiding the one offs when you use @ aliases, so I guess that's not necessary after all.
Pushed by dwillcoxon@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/56992c2597a4 Update search results when the selected one-off button changes. r=dao
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
Description
•