1527947 - QuantumBar: Moving selection to one-off search buttons doesn't update the "Search with" action text

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Mark Banner (:standard8)]

STR:

1. Start typing in the urlbar with something that will result in the first item being "Search with <engine>"
2. Press alt + arrow down.
3. As you then navigate through the one-off buttons, observe the "Search with" text.

Expected Results

=> "Search with <engine>" is updated as the one-off button changes.

Actual Results

=> The text is not updated.

This currently causes part of browser_urlbarOneOffs.js to fail.

Comment 2

[Drew Willcoxon :adw]

Copying my comment from bug 1528408:

For the awesomebar, it's handled here: https://searchfox.org/mozilla-central/rev/8e8ccec700159dc4efe061cfec2af10b21a8e62a/browser/base/content/urlbarBindings.xml#2642

Not directly related to this bug, but we need to listen for one-off selection changes to properly implement search alias highlighting too.

Comment 3

[Drew Willcoxon :adw]

Attachment: Bug 1527947 - Update search results when the selected one-off button changes.

Comment 4

[Drew Willcoxon :adw]

(In reply to Drew Willcoxon :adw from comment #2)

Not directly related to this bug, but we need to listen for one-off
selection changes to properly implement search alias highlighting too.

Actually we should be hiding the one offs when you use @ aliases, so I guess that's not necessary after all.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/56992c2597a4
Update search results when the selected one-off button changes. r=dao

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/56992c2597a4