Closed Bug 1528080 Opened 9 months ago Closed 8 months ago

Telemetry for TRACKING_PROTECTION_SHIELD histogram is incorrect

Categories

(Core :: Privacy: Anti-Tracking, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox68 --- fixed

People

(Reporter: ewright, Assigned: ewright)

References

Details

(Whiteboard: [anti-tracking])

Attachments

(1 file)

In content/browser-contentblocking.js the function onContentBlockingEvent is activated for every content blocking event, including things like opening the control panel.

The code within it seems to be written to expect to be triggered once per page load. This causes multiple additions to the TRACKING_PROTECTION_SHIELD histogram, I have seen 9-15 times per page load.

You can observe this by going to about:telemetry, searching for the probe "TRACKING_PROTECTION_SHIELD". Open another tab and refresh that page. flip back to the original tab and you will see the probe jump by many entries, despite the probe being described as the "Status of the shield icon for each top-level pageload"

The rest of the code in that function is also being run an extra amount of times, though seems to have no obvious negative side effects.

Assignee: nobody → ewright
Priority: -- → P1
Target Milestone: --- → mozilla67
Status: NEW → ASSIGNED
Depends on: 1522919

The shield historgram was reporting once per content blocking event, now it reports per page load.

Pushed by ewright@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8bfb359646bf
Telemetry for shield histogram reports per page load. r=johannh
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.