1528090 - `pageActionSeparator` is now permanently visible

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P1)

Description

[Bruce]

chrome://browser/skin/browser.css has:

#page-action-buttons > :not([hidden]) ~ #pageActionSeparator {
    visibility: visible;
}

which will now always apply because the newly introduced toolbartabstop child of #page-action-buttons precedes #pageActionSeparator.

Comment 1

[Marco Zehe (:MarcoZ)]

I guess this is part of the styling fixes Yura is assigned to work on after this initial landing of the new keyboard nav stuff. See bug 1506510. NI'ing Yura for info.

Comment 2

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Bug 1528090 - ensure that the urlbar page action separator is not visible because of toolbartabstop. r=dao

MozReview-Commit-ID: C81oYaPsuAd

Comment 3

[Yura Zenevich [:yzen] (please use "needinfo")]

(In reply to Marco Zehe (:MarcoZ) from comment #1)

I guess this is part of the styling fixes Yura is assigned to work on after this initial landing of the new keyboard nav stuff. See bug 1506510. NI'ing Yura for info.

thanks

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/510bae6520ad
ensure that the urlbar page action separator is not visible because of toolbartabstop. r=dao

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/510bae6520ad

Comment 6

[Yura Zenevich [:yzen] (please use "needinfo")]

Fixed, removing ni