Closed Bug 1528151 Opened 5 years ago Closed 5 years ago

Flush style before calling getProperties?

Categories

(DevTools :: Inspector: Animations, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: birtles, Unassigned)

References

Details

In bug 1524480 I am about to make it so that some methods on Animations no longer flush style.

This could cause intermittent failures if there are animation inspector tests that mutate animations using the Web Animations API and then immediately cause DevTools to inspect the animations' properties without doing anything that triggers flushing style in the meantime. (If, for example, DevTools calls getAnimations() or getComputedStyle() at any point in between then style will be flushed and there will be no problem.)

I suspect there is no problem, but if there is we might need to, for example, cause getProperties() to explicitly flush style there:

https://searchfox.org/mozilla-central/rev/38035ee92463c9e9fbca729ac7e66476ac7eb27a/devtools/server/actors/animation.js#411

Anyway, feel free to close this as invalid. I'm just filing it as a heads up for now and in case we encounter any problem.

Hey Daisuke, this appeared on our triage today. Could you add a note if this is a problem and assign a priority if so? Thanks

Flags: needinfo?(dakatsuka)

I talked with Brian. Because it seems this have not caused any oranges so far, please let me flag as invalid.

Status: NEW → RESOLVED
Closed: 5 years ago
Flags: needinfo?(dakatsuka)
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.